Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove early padding mechanism #16

Closed
ma3ke opened this issue Mar 22, 2024 · 0 comments · Fixed by #18
Closed

Remove early padding mechanism #16

ma3ke opened this issue Mar 22, 2024 · 0 comments · Fixed by #18

Comments

@ma3ke
Copy link
Collaborator

ma3ke commented Mar 22, 2024

Perhaps we should just remove the whole padding mechanism.

We merely want to say: if it's out of bounds, we shouldn't place it.

For now, I implemented a total cope to deal with the weird fft behavior. The weird behavior occurred with non-connected shapes in 2D.
@ma3ke ma3ke linked a pull request Mar 27, 2024 that will close this issue
Remove padding scheme and rely on valid mode for convolution #18
Merged
@ma3ke ma3ke mentioned this issue Mar 27, 2024
Merged
ma3ke added a commit that referenced this issue Mar 27, 2024
@ma3ke
Remove padding scheme and rely on valid mode for convolution
c66fff8 
This change reverts the padding scheme I had introduced earlier to
circumvent an issue that I now know can be solved much more simply and
elegantly.

Closes #16
@ma3ke ma3ke changed the title Padding question Remove early padding mechanism Mar 27, 2024
@ma3ke ma3ke closed this as completed in #18 Mar 28, 2024
ma3ke added a commit that referenced this issue Mar 28, 2024
@ma3ke
Remove padding scheme and rely on valid mode for convolution
60571d4 
This change reverts the padding scheme I had introduced earlier to
circumvent an issue that I now know can be solved much more simply and
elegantly.

Closes #16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove padding scheme and rely on valid mode for convolution marrink-lab/bentopy
1 participant
@ma3ke