Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missed chapters to an already downloaded novel #28

Open
feahnthor opened this issue Oct 26, 2023 · 3 comments
Open

Add missed chapters to an already downloaded novel #28

feahnthor opened this issue Oct 26, 2023 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@feahnthor
Copy link
Member

Problem


A feature needs to be added to add individual chapters, whether or not this will be a standalone commandline option will be determined later. This will be useful for cases like the image below where chapters could not be loaded, so an incomplete file was created, another useful use is for those who would only like to get only the most recent or particular range of chapters from a series.

image

Possible things to do. May change as i go along

  1. This needs to be implemented for each of the possible file types Benny-Scraper currently supports. i.e. Pdf, Epub, and all ComicbookArchives.
  2. Files that will need to be touched in order to get this working. U
    a. NovelProcessor.cs - the AddNewNovelAysnc, UpdateExistingNovelAsync
    b. ScraperStrategy.cs the FetchContentByAttribute method, as this is what actually grabs our chapters urls from the websites. It may be a good idea to add a new attribute, if so then we need to create a way for users to enter the range of chapters or specific urls when the application runs.
    c. All the Generator files, PdfGenerator EpubGenerator, ComicBookArchiveGenerator- ensure they will update or add these chapters without a problem. d.Program.cscommand line region, I think it might be easier to add this as a command line feature first. So a new option will need to be made in theCommandlineOptions.cs`
  3. It might be a good idea to create a column that checks if a novel is not missing chapters when installed. When doing a quick search I found that at least for novels with images, the chapters will be skipped entirely when being added to the database. Notice how the chapter number 45 is missing as the image above shows.
select p.id, p.chapter_id, c.title, c.number, p.image, p.url from novel
inner join chapter as c
on c.novel_id = novel.id
join page as p
on p.chapter_id = c.id
where novel.id = 'ABEA4D61-9685-46FA-AE3A-3E4B48E9CD7B'
order by c.number asc;

image

@feahnthor feahnthor added the enhancement New feature or request label Oct 26, 2023
@feahnthor feahnthor self-assigned this Oct 26, 2023
@masteoo
Copy link

masteoo commented Dec 22, 2023

@feahnthor hello, sorry to disturb, I am not a programmer maybe you can help me. How can I download this long novel in pdf or epub please? Thanks

@feahnthor
Copy link
Member Author

@feahnthor hello, sorry to disturb, I am not a programmer maybe you can help me. How can I download this long novel in pdf or epub please? I have only S8 tab. Thanks https://noveldrama.com/virginity-in-second-marriages-bd6512.html#chapter-list

@masteoo While adding the noveldrama site would be an easy task that I could use to finally write up documentation for adding new sites, having the application run on a tablet or mobile device is not possible at the moment (or ever). The changes that would require are not something, I plan to do anytime soon. Here are your possible options on how to get this done on your tablet.

  1. Your best option would be to choose another repository that allows you get things done on a mobile device. One that comes to mind is https://github.com/dteviot/WebToEpub, there is even a section they briefly go over mobile. You could also check for other repositories.
  2. If you still wanted to use this application and have this noveldrama added as an available site, this would require you to get access of a desktop computer (either through physical or remote means), or something able to run, Mac OS, Linux, or Windows, as this was built to be a desktop application.

I hope this answers your question satisfactorily.

P.S.
Next time you can just create a new issue or email me, instead of commenting on an unrelated closed issue.

@feahnthor
Copy link
Member Author

While I am not a limited by terms of service as dteviot pointed out, I, and most likely others who create scraping applications are required to follow the law. Which in this case, creating then giving you a copy of a work would be redistribution of Copyrighted material, which is illegal. That is why we create tools for a user's personal use.

As I said, I can add the site to my application is you create an issue, I can even have it added before the end of the year, but you would need to get access to a PC to run the application yourself.

@feahnthor feahnthor reopened this Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants