getDatastoreEntries return empty array when no value

[Thykof]

I would like to investigate why getDatastoreEntries returns an empty Uint8Array in the final_value while it's supposed to return null.

In the case the key in the smart contract datastore is getting inserted in an operation not final, we should get null.
In the case the key in the smart contract datastore is getting inserted in an operation no executed yet, we should get null.

cc @gregLibert @AurelienFT this is a follow up issue after the late debugging session.

[pivilartisant]

Still present as of December 2024

[SlnPons]

@peterjah any idea on this bug? Should we priorise it?

[Leo-Besancon]

For me it's related to this line: https://github.com/massalabs/massa-web3/blob/dc6018c0f148630a7996f572cf9eb88335497a2e/src/client/publicAPI.ts#L161C7-L161C40

If we want to return null, we should not return Uint8Array.from(val ?? []), but return null if val is null, and Uint8Array.from(val) if val is not null.

But as I'm not a js dev I'll let someone else impl the fix, I'm not sure of the side effects or if I'm 100% right.

[damip]

@peterjah WDYT ?

[peterjah]

lets to it!