Incorrect package deploy to npm

[Shaquu]

Hi,
package got release to npm without dist folder.
It is unusable Module not found: Can't resolve '@material-table/core'

[peacechen]

@oze4
material-table was set up such that main points to the dist folder:
https://github.com/material-table-core/core/blob/master/package.json#L8

That folder is created during npm run build transpilation. Before publishing, always run npm run build, which should be added to the CI/CD script.
Alternatively, you could point main to src/index.js to avoid the build step. That may not play nice with projects that don't have all the necessary babel plugins. We need to test whether the code depends on experimental plugins.

[matthewoestreich]

I did build before publishing (dist folder was created and everything).

Give me a couple minutes and I'll check this out.

Apologies.

[matthewoestreich]

@Shaquu @peacechen apologies this has been resolved.

[matthewoestreich]

@Shaquu @peacechen see here https://github.com/material-table-core/core/releases/tag/v2.1.4 and here #10 for more.

[matthewoestreich]

I tested @material-table/core, v2.1.4 as well to make sure it's working (it is).

[peacechen]

Thanks @oze4 !

[thefat32]

@oze4 you can unpublish broken versions with npm unpublish since it has not been 48hs since deploy. If you need me to handle any task regarding npm or deploys just add me to material-table-core org!

[matthewoestreich]

@thefat32 invite has been sent. (to the email listed on your github profile)

[matthewoestreich]

@Domino987 @peacechen @thefat32 @Shaquu

Please see here. I have configured GH Actions to automatically publish NPM package, only if certain params are met..

[Shaquu]

You could make it work on new tag instead of commit message

[thefat32]

Great!

[matthewoestreich]

@Shaquu I'm down for whatever everyone feels is best. I honestly have no preference. If you prefer via tag, let's change it.