Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create proper login page/actually log out when using Okta #149

Open
mbland opened this issue Oct 17, 2017 · 0 comments
Open

Create proper login page/actually log out when using Okta #149

mbland opened this issue Oct 17, 2017 · 0 comments
Milestone

Comments

@mbland
Copy link
Owner

mbland commented Oct 17, 2017

Right now, when accessing the server, you're instantly redirected to the auth provider's login page. If the login fails, you're immediately redirected back to that page.

Most of the time this isn't an issue, but if the user is legitimately logged in and there's a problem with the auth flow on our side, this manifests as a "too many redirects" error.

It'd be better to log the error in the /auth/callback endpoint, and present a proper /login endpoint or some such.

cc: @akashvbabu

@mbland mbland added this to the v1.0.0 milestone Oct 17, 2017
@mbland mbland changed the title Create proper login page Create proper login page/actually log out when using Okta Nov 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant