-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pre-release revisions and alignment with CDS v5.0.4 #169
Open
Bankso
wants to merge
107
commits into
main
Choose a base branch
from
12-2024-updates
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sequencing Level 1 model contains everything needed, so GeoMx Level 1 can be limited to just GeoMx-specific attributes
Sequencing Level 2 model contains everything needed, so GeoMx Level 2 can be limited to just GeoMx-specific attributes
Sequencing Level 3 model contains everything needed, so GeoMx Level 3 can be limited to just GeoMx-specific attributes
Already contained in Sequencing Level 1
Include attributes from shared that capture workflow details
- added DSP Dataset Metadata attribute and added to schema def - update descriptions to provide better guidance
Add "Metadata" as a file level, to help indicate that the information must be mapped onto a metadata template
CV updates from script
Using schematic 24.12.1
Add attribute GeoMx Imaging AOI Coordinates and update schema definition. This attribute allows a submitter to identify specific coordinate/mask files to be used with a GeoMx image
Using schematic 24.12.1
Retain Publication Dataset Alias to simplify curation and database updates
Move json to json_schemas and csvs to templates
Add output file handling
Replace Component Key attributes in Collection with Component Table Id attributes, which will be used to log table subsets generated for sharing alongside file Datasets
Using schematic v24.12.1
Add data type qualifier to description
Added DOI attributes for Dataset View, Tool View, and Educational Resource models Also added Keys to Educational Resource, but retained tool and dataset link attributes, in case the ed res uses resources from outside of Synapse
For mapping and conversion
Align valid values from CDS v5.0.4
Align valid values from CDS v5.0.4
Align valid values from CDS v5.0.4
Align valid values from CDS v5.0.4
Align valid values from CDS v5.0.4
Align valid values from CDS v5.0.4
Align valid values from CDS v5.0.4
These are stored in visium-specific folders
Remove unneeded attributes, covered by File View template
These values live in sequencing-specific folders, CSVs in shared were redundant
Equivalent to tissueOrganOriginCDS.csv, so I deleted this file and replaced mapping reference with reference to tissueOrganOriginCDS.csv
Align mappings with current set of valid values
Added Biospecimen Treatment Response, Incidence Type Added valid values for Acquisition method Removed Biospecimen Pathology
Updated by update valid values script
Updated by update valid values script
Updated by update valid values script
Updated by update valid values script
Updated by update valid values script
Updated by update valid values script; Moved attributes NGS Raw Reads and NGS Unique Bases from sequencing level 2 to sequencing level 1 and added to level 1 model definition. These are requested by CDS model
Updated by update valid values script; removed attributes now in sequencing level 1
Updated by update valid values script
Updated by update valid values script
via make
generated via schematic 24.12.1
This will be maintained locally until a clear need for storage in the repo is identified
@aditigopalan please let me know if anything looks off! I was able to generate a google sheet template using the JSON-LD, so it at least works 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #151 and adds DOI columns noted in #159
This is an extension of the data model refactor and alignment with CDS model v5.0.4.
This update reflects the current Synapse table schemas used in grant-specific projects and UNION tables for GrantView, PublicationView, DatasetView, ToolView, and EducationalResource components.
Also included in this update are updated models for participant, specimen, file, and assay metadata, aligned with CDS v5.04 and mapped via this document.
Changelog
Added valid values for CDS data model, v5.0.4
Added study- and specimen-focused attributes, to better address some data elements requested by CDS model
Added DOI columns for Dataset View, Tool View, and Educational Resource models
Removed GeoMx attributes covered by Sequencing models
Added missing "Key" attributes, to support data model linkages
Specific model types mapped to CDS 5.0.4 and updated:
Models are also available for: