Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking change for API key #41

Open
jaggedsoft opened this issue Sep 22, 2019 · 0 comments
Open

Breaking change for API key #41

jaggedsoft opened this issue Sep 22, 2019 · 0 comments

Comments

@jaggedsoft
Copy link
Contributor

The old version had this format: Client(address, privKey) but the new version has this format Client(apiKey, address, privKey)

If you leave the api key out and use it like the old format (address, privatekey) it sends the private key as the address to idex servers. So people who update the code but don't add the api key get their private key sent to IDEX servers and it returns Invalid address

Maybe do a sanity check for required 3rd parameter on Client instantiation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant