Skip to content
This repository has been archived by the owner on Mar 30, 2020. It is now read-only.

incorrect code comments #8

Open
ag9920 opened this issue Oct 22, 2019 · 0 comments
Open

incorrect code comments #8

ag9920 opened this issue Oct 22, 2019 · 0 comments

Comments

@ag9920
Copy link

ag9920 commented Oct 22, 2019

Hi, I noticed the comment for CompareSimple method might be wrong. Please double check it.

Just the same of CompareVersion but return a int result, 0 if both version are equal, 1 if the right side is bigger and -1 if the right side is lower

In the given example, version.CompareSimple("1.2", "1.0.1") returns 1. I think that means "1.2" is bigger than 1.0.1. So the comment should replace "right side" with "left side".

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant