Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing xlink to SVG simplified example #37757

Closed
TriMoon opened this issue Jan 22, 2025 · 1 comment · Fixed by #37900
Closed

Add missing xlink to SVG simplified example #37757

TriMoon opened this issue Jan 22, 2025 · 1 comment · Fixed by #37900
Labels
Content:SVG SVG docs goal: consistency (Experimental label) Issues about inconsistent/conflicting/contradictory content. good first issue A good issue for newcomers to get started with.

Comments

@TriMoon
Copy link

TriMoon commented Jan 22, 2025

MDN URL

https://developer.mozilla.org/en-US/docs/Web/SVG/Tutorial/SVG_and_CSS

What specific section or headline is this issue about?

https://developer.mozilla.org/en-US/docs/Web/SVG/Tutorial/SVG_and_CSS#simplified_structure

What information was incorrect, unhelpful, or incomplete?

The stylesheet isn't linked into the document...

<svg
width="600px"
height="600px"
viewBox="-300 -300 600 600"
xmlns="http://www.w3.org/2000/svg"
xmlns:xlink="http://www.w3.org/1999/xlink">
<title>SVG demonstration</title>
<desc>Mozilla CSS Getting Started - SVG demonstration</desc>

What did you expect to see?

@@ -431,2 +431,2 @@
-  <title>SVG demonstration</title>
+  <link
+    xmlns="http://www.w3.org/1999/xhtml"
+    rel="stylesheet"
+    href="style8.css"
+    type="text/css" />
+  <title>SVG demonstration</title>

Do you have any supporting links, references, or citations?

No response

Do you have anything more you want to share?

This was just an observation of the provided code, no matter if the styles are actually applied or not due to the discussion mentioned...

MDN metadata

Page report details
@TriMoon TriMoon added the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label Jan 22, 2025
@github-actions github-actions bot added the Content:SVG SVG docs label Jan 22, 2025
@caugner caugner added the goal: consistency (Experimental label) Issues about inconsistent/conflicting/contradictory content. label Jan 24, 2025
@Josh-Cena Josh-Cena added good first issue A good issue for newcomers to get started with. and removed needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. labels Jan 30, 2025
@mohanad-80
Copy link
Contributor

Hi, I’d like to work on this issue. Could anyone please assign it to me? I’ll open a PR soon.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:SVG SVG docs goal: consistency (Experimental label) Issues about inconsistent/conflicting/contradictory content. good first issue A good issue for newcomers to get started with.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants