Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use of "protected" keyword in constructor param #8

Open
halmos opened this issue Jun 5, 2024 · 0 comments
Open

Use of "protected" keyword in constructor param #8

halmos opened this issue Jun 5, 2024 · 0 comments

Comments

@halmos
Copy link

halmos commented Jun 5, 2024 •
edited
Loading

Detailed description

The MatrixClient constructor includes a param with the protected keyword that causing pho to throw. see:

php-matrix-sdk/src/MatrixClient.php

Line 117 in 1efbade

protected $encryptionConf = [],

I believe this is a PHP 8 feature, but the readme indicates a requirement of PHP 7.4.

Context

The class cannot be used currently.

Possible implementation

Remove the protected keyword.

Your environment

Include as many relevant details about the environment you experienced the bug in and how to reproduce it.

  • PHP 7.4.33
  • OSX 14.3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@halmos