Skip to content
This repository has been archived by the owner on Feb 10, 2023. It is now read-only.

Edge case: Daylight savings time #119

Open
mellowagain opened this issue Mar 31, 2019 · 1 comment
Open

Edge case: Daylight savings time #119

mellowagain opened this issue Mar 31, 2019 · 1 comment
Labels
feature: io type: bug Issues which describe a issue or bug
Milestone

Comments

@mellowagain
Copy link
Owner

Today the clocks have been shifted at 2am directly 3am because of Daylight savings time. Shiro however did not update the presence for the user and thus didn't shift the timezone by one. The in-game osu! time was thus outdated.

An already existing dependency of Shiro, Hinnat Date, has the ability to handle daylight savings time using it's Timezone feature. Implementing this should thus be trivial.

@mellowagain mellowagain added type: bug Issues which describe a issue or bug feature: io labels Mar 31, 2019
@mellowagain mellowagain added this to the Backlog milestone Mar 31, 2019
@48cf
Copy link
Collaborator

48cf commented Feb 25, 2020

I believe it's a bug with osu! client - the time offset is sent to the server on the first request, it already accounts for that, but while the client is connected it can't send the updated time zone, thus the time is off.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature: io type: bug Issues which describe a issue or bug
Projects
None yet
Development

No branches or pull requests

2 participants