Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resetting fitter states if references to their AAMs/CLMs are changed? #15

Open
jalabort opened this issue Jan 6, 2015 · 1 comment
Open

Comments

@jalabort
Copy link
Member

jalabort commented Jan 6, 2015

Shiyang run onto a bit of weird problem today. He has an algorithm that given an AAM produces a new AAM whose shape/appearance means and components are a modified version of those of the original one. His idea was to create a Fitter around the first AAM and then simply replace the AAM with the AAM output of his algorithm (fitter.aam = new_aam). He was expecting the fitter to work as if it was created using the new AAM which did not hapend due to the fitter having some inner state that was computed on construction. While this is not a massive problem (since he can always build a new fitter...) I can see why he though that would work... Since fitter.aam is public, maybe we should put a setter on it so that fitter._set_up is automatically called if the aam is reset... Sensible?

@patricksnape
Copy link
Contributor

Sounds pretty sensible to me. Either that or make the AAM private.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants