Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace postgres.py with SQLAlchemy #2

Open
patricksnape opened this issue Aug 18, 2016 · 1 comment
Open

Replace postgres.py with SQLAlchemy #2

patricksnape opened this issue Aug 18, 2016 · 1 comment

Comments

@patricksnape
Copy link
Contributor

This will make it much much simpler to support many database backends. It also makes martialling the returned objects much more simple. We would have to play a bit with the default table creation depending on of the json type exists or not, but that shouldn't be too hard (full back to just a blob and stringify the json).

@jabooth
Copy link
Member

jabooth commented Aug 19, 2016

True this would make it much nicer to maintain, especially if we expand out what we are storing in the DB a little.

My worry with an ORM is that I really like the simplicity of what we have now - I can manually inspect the schema with a DB browser like Postico, make a few changes directly, and know I'm not screwing anything up. Would we have the same level of robustness with SQLAlchemy? (I'm asking as I really don't know btw, not rhetorical!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants