Time-dependent demo (bubble shear) #158
Conversation
ddundo
added
documentation
demos/bubble_shear.py
Outdated
| try: | ||
| H_interp.interpolate(H) | ||
| except NameError: | ||
| H_interp.interpolate(Constant(((1.0, 0.0), (0.0, 1.0)))) |
There was a problem hiding this comment.
I had to add this try-except because MongeAmpereMover calls monitor during initialisation. Here's the error without it:
Traceback (most recent call last):
File "/home/firedrake/firedrake/src/movement/demos/bubble_shear.py", line 114, in <module>
mover = MongeAmpereMover(mesh, monitor, method="quasi_newton", rtol=1e-8)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/firedrake/firedrake/src/movement/movement/monge_ampere.py", line 87, in MongeAmpereMover
return implemented_methods[method](mesh, monitor_function, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "petsc4py/PETSc/Log.pyx", line 188, in petsc4py.PETSc.Log.EventDecorator.decorator.wrapped_func
File "petsc4py/PETSc/Log.pyx", line 189, in petsc4py.PETSc.Log.EventDecorator.decorator.wrapped_func
File "/home/firedrake/firedrake/src/movement/movement/monge_ampere.py", line 586, in __init__
super().__init__(mesh, monitor_function=monitor_function, **kwargs)
File "/home/firedrake/firedrake/src/movement/movement/monge_ampere.py", line 148, in __init__
super().__init__(mesh, monitor_function=monitor_function, **kwargs)
File "/home/firedrake/firedrake/src/movement/movement/mover.py", line 77, in __init__
self._create_functions()
File "/home/firedrake/firedrake/src/movement/movement/monge_ampere.py", line 601, in _create_functions
super()._create_functions()
File "/home/firedrake/firedrake/src/movement/movement/monge_ampere.py", line 181, in _create_functions
self.monitor.interpolate(self.monitor_function(self.mesh))
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/firedrake/firedrake/src/movement/demos/bubble_shear.py", line 99, in monitor
H_interp.interpolate(H)
^
NameError: name 'H' is not defined. Did you mean: 'H1'?
demos/bubble_shear.py
Outdated
| mover = MongeAmpereMover(mesh, monitor, method="quasi_newton", rtol=1e-8) | ||
| c_mov = get_initial_condition(mover.mesh) | ||
| movement_simulation = run_simulation(mover.mesh, 0.0, simulation_end_time, c_mov) | ||
| t = 0 | ||
| H = RiemannianMetric(TensorFunctionSpace(mover.mesh, "CG", 1)) |
There was a problem hiding this comment.
Would this not fix your issue? Ensure H exists before it's needed.
| mover = MongeAmpereMover(mesh, monitor, method="quasi_newton", rtol=1e-8) | |
| c_mov = get_initial_condition(mover.mesh) | |
| movement_simulation = run_simulation(mover.mesh, 0.0, simulation_end_time, c_mov) | |
| t = 0 | |
| H = RiemannianMetric(TensorFunctionSpace(mover.mesh, "CG", 1)) | |
| H = RiemannianMetric(TensorFunctionSpace(mover.mesh, "CG", 1)) | |
| mover = MongeAmpereMover(mesh, monitor, method="quasi_newton", rtol=1e-8) | |
| c_mov = get_initial_condition(mover.mesh) | |
| movement_simulation = run_simulation(mover.mesh, 0.0, simulation_end_time, c_mov) | |
| t = 0 |
There was a problem hiding this comment.
Thanks! Although I left this in more as a reminder to ask you whether we really need to call the monitor function during initialisation, since it gets called again during mover.move(). Seems like it could be optimised.
There was a problem hiding this comment.
Oh and maybe not, since RiemannianMetric (and the solution) needs to be defined on mover.mesh - I think?
There was a problem hiding this comment.
Ah yes, of course - apologies.
|
Just to clarify what I meant during the meeting when I suggested passing args/kwargs to the monitor function: def monitor(mesh, solution):
...
def run_simulation(...):
...
mover = MongeAmpereMover(...)
while float(t) < t_end + 0.5 * float(dt):
lvs.solve() # solve for c
mover.move(c) # pass c to monitorOr we could do it more explicitly, for example: monitor_kwargs = {"solution": c}
mover.move(**monitor_kwargs) |
Thanks. I guess one question I have is why do we need to define |
You're right, no need to complicate it for now. I inlined them in ac24b50. Still fiddly with the |
Closes #157.
Based on Animate's bubble shear demo.