Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XRequest Error Response JSON Format #123

Open
d3ep4k opened this issue May 12, 2020 · 3 comments
Open

XRequest Error Response JSON Format #123

d3ep4k opened this issue May 12, 2020 · 3 comments
Assignees

Comments

@d3ep4k
Copy link
Contributor

d3ep4k commented May 12, 2020

XRequest error response is added as a string. Convert it to a valid json format along with other parts of the output. It prints correctly when there is a valid response. But only in the case of an invalid response we get a string output as follows.

"XRequest error: Response{protocol=http/1.1, code=403, message=Forbidden, url=https://github.com/covid/v1.0/pos}"
@ancode4
Copy link
Member

ancode4 commented May 24, 2020

66a0730
Fixed such that you only get the message in the response body.

If you want to know the statusCode, you can use outputHeaders=true, so you understand whether the response was successful or not.

@d3ep4k
Copy link
Contributor Author

d3ep4k commented Jul 27, 2020

@ancode4 can this issue be closed then?

@ancode4
Copy link
Member

ancode4 commented Jul 27, 2020

Yes but you need to add it in the docs somewhere

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants