-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: Common-API is not published with intermediate mappings (Fabric) #3451
Comments
This has been automatically marked as stale because it has not had recent activity, and will be closed if no further activity occurs. If this was overlooked, forgotten, or should remain open for any other reason, please reply here to call attention to it and remove the stale status. Thank you for your contributions. |
This issue is still not resolved on version 15.3.0.7, making it impossible to use this API with yarn mappings (unless there is a way to remap it by myself?). |
Thanks for the report! |
So the only way to support JEI is to switch to mojmaps? |
I might have finally been able to fix this simply, here: d05376b |
This is still an issue but I think I have a way forward. |
This has been fixed in JEI for 1.21.1 ( modImplementation("mezz.jei:jei-${minecraft_version}-fabric-api:${jei_version}")
modRuntimeOnly("mezz.jei:jei-${minecraft_version}-fabric:${jei_version}") and it will pull in an intermediary mapping version of common-api automatically. If you have a multi-project and want to depend on the intermediary mapping version of common-api directly, you can do it with modImplementation("mezz.jei:jei-${minecraft_version}-common-api-intermediary:${jei_version}") (all this is visible on the maven, for example here's 1.21.1: https://maven.blamejared.com/mezz/jei/jei-1.21.1-common-api-intermediary/) |
Hmm it look fine to me, please check your gradle setup @unilock. I checked and the source jar looks correct too |
Hmm, decompiling the jar manually does show the correct Intermediary mappings... maybe clearing the Gradle caches would've fixed it? I don't have that development environment set up at the moment, anyway. |
Steps to Reproduce the Bug
Implement JEI in a fabric mod that is not using parchment mappings. The fabric example mod is sufficient.
Expected Behavior
Adding JEI to a project should remap the API to your project's mappings.
Actual Behavior
Remapping works for the fabric-api, however the common-api does not have intermediate mappings and is stuck on parchment. For example, the method
getPluginUid()
, claims to require the return typenet.minecraft.resources.ResourceLocation
which doesn't exist, instead ofnet.minecraft.util.Identifier
which is the same class under Yarn mappings.Mod Pack URL (Optional)
No response
Mod Pack Version (Optional)
No response
Extra Notes (Optional)
No response
latest.log
No response
The text was updated successfully, but these errors were encountered: