Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need for code to undergo changes #4

Open
thak123 opened this issue Oct 27, 2016 · 3 comments
Open

Need for code to undergo changes #4

thak123 opened this issue Oct 27, 2016 · 3 comments

Comments

@thak123
Copy link

thak123 commented Oct 27, 2016

The dynet lib used in the code (previously known cnn ) has older references which needs to changed from cnn to dynet . I have spent nice 6 hours on figuring out the issue :'(. Got it working though,

Anyone facing issue change the train-sep-morph files cnn references to dynet

@mfaruqui
Copy link
Owner

Hi Gaurish,

Thanks! If you were able to run the code with the modifications, I'll be happy to merge your code, if you can send a commit.

@thak123
Copy link
Author

thak123 commented Oct 28, 2016

Hi Mr Faruqui,

Will send the commit for merging. Give me some time . Need to figure out how this commit thing works .:D

@thak123 thak123 closed this as completed Oct 28, 2016
@thak123 thak123 reopened this Oct 28, 2016
@thak123
Copy link
Author

thak123 commented Nov 20, 2016

Sorry Manaal what I thought was working initially is isnt the correct way. I had literally hacked in the changes to the code. Kindly please do the refactoring of the code and commit the changes as it is becoming more complex and more difficult to solve the issue with dynet library also previous cnn repo has undergone a lot of changes and the make file throws errors on compiling. I request you to please do the needful asap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants