From 838674ef6c60aad501d20b901326db4388e436d8 Mon Sep 17 00:00:00 2001 From: Germain AUBERT Date: Mon, 25 Jul 2022 22:37:09 +0200 Subject: [PATCH] #64 fix javadoc issues --- gltf/src/net/mgsx/gltf/data/extensions/KHRLightsPunctual.java | 4 ++-- .../data/extensions/KHRMaterialsPBRSpecularGlossiness.java | 4 ++-- gltf/src/net/mgsx/gltf/data/extensions/KHRMaterialsUnlit.java | 4 ++-- .../net/mgsx/gltf/data/extensions/KHRTextureTransform.java | 4 ++-- gltf/src/net/mgsx/gltf/scene3d/shaders/PBRShaderProvider.java | 2 -- gltf/src/net/mgsx/gltf/scene3d/utils/IBLBuilder.java | 2 +- 6 files changed, 9 insertions(+), 11 deletions(-) diff --git a/gltf/src/net/mgsx/gltf/data/extensions/KHRLightsPunctual.java b/gltf/src/net/mgsx/gltf/data/extensions/KHRLightsPunctual.java index 2bf74292..face4ea1 100644 --- a/gltf/src/net/mgsx/gltf/data/extensions/KHRLightsPunctual.java +++ b/gltf/src/net/mgsx/gltf/data/extensions/KHRLightsPunctual.java @@ -13,8 +13,8 @@ import net.mgsx.gltf.scene3d.lights.SpotLightEx; /** - * {@link net.mgsx.gltf.data.scene.GLTFNode} and {@link net.mgsx.gltf.data.GLTF} (root) extension - * @see https://github.com/KhronosGroup/glTF/tree/master/extensions/2.0/Khronos/KHR_lights_punctual + * {@link net.mgsx.gltf.data.scene.GLTFNode} and {@link net.mgsx.gltf.data.GLTF} (root) extension. + * See https://github.com/KhronosGroup/glTF/tree/master/extensions/2.0/Khronos/KHR_lights_punctual */ abstract public class KHRLightsPunctual { diff --git a/gltf/src/net/mgsx/gltf/data/extensions/KHRMaterialsPBRSpecularGlossiness.java b/gltf/src/net/mgsx/gltf/data/extensions/KHRMaterialsPBRSpecularGlossiness.java index 915d5553..0f9af48b 100644 --- a/gltf/src/net/mgsx/gltf/data/extensions/KHRMaterialsPBRSpecularGlossiness.java +++ b/gltf/src/net/mgsx/gltf/data/extensions/KHRMaterialsPBRSpecularGlossiness.java @@ -3,8 +3,8 @@ import net.mgsx.gltf.data.texture.GLTFTextureInfo; /** - * {@link net.mgsx.gltf.model.material.GLTFMaterial} extension (deprecated now) - * @see https://github.com/KhronosGroup/glTF/blob/main/extensions/2.0/Archived/KHR_materials_pbrSpecularGlossiness/README.md + * {@link net.mgsx.gltf.data.material.GLTFMaterial} extension (deprecated now). + * See https://github.com/KhronosGroup/glTF/blob/main/extensions/2.0/Archived/KHR_materials_pbrSpecularGlossiness/README.md */ public class KHRMaterialsPBRSpecularGlossiness { diff --git a/gltf/src/net/mgsx/gltf/data/extensions/KHRMaterialsUnlit.java b/gltf/src/net/mgsx/gltf/data/extensions/KHRMaterialsUnlit.java index 1891b5c6..d7730195 100644 --- a/gltf/src/net/mgsx/gltf/data/extensions/KHRMaterialsUnlit.java +++ b/gltf/src/net/mgsx/gltf/data/extensions/KHRMaterialsUnlit.java @@ -1,8 +1,8 @@ package net.mgsx.gltf.data.extensions; /** - * {@link net.mgsx.gltf.data.material.GLTFMaterial} extension - * @see https://github.com/KhronosGroup/glTF/blob/master/extensions/2.0/Khronos/KHR_materials_unlit + * {@link net.mgsx.gltf.data.material.GLTFMaterial} extension. + * See https://github.com/KhronosGroup/glTF/blob/master/extensions/2.0/Khronos/KHR_materials_unlit */ public class KHRMaterialsUnlit { public static final String EXT = "KHR_materials_unlit"; diff --git a/gltf/src/net/mgsx/gltf/data/extensions/KHRTextureTransform.java b/gltf/src/net/mgsx/gltf/data/extensions/KHRTextureTransform.java index e83c8de5..72f1c3c3 100644 --- a/gltf/src/net/mgsx/gltf/data/extensions/KHRTextureTransform.java +++ b/gltf/src/net/mgsx/gltf/data/extensions/KHRTextureTransform.java @@ -1,8 +1,8 @@ package net.mgsx.gltf.data.extensions; /** - * {@link net.mgsx.gltf.model.texture.GLTFTextureInfo} extension - * @see https://github.com/KhronosGroup/glTF/blob/master/extensions/2.0/Khronos/KHR_texture_transform/README.md + * {@link net.mgsx.gltf.data.texture.GLTFTextureInfo} extension. + * See https://github.com/KhronosGroup/glTF/blob/master/extensions/2.0/Khronos/KHR_texture_transform/README.md */ public class KHRTextureTransform { public static final String EXT = "KHR_texture_transform"; diff --git a/gltf/src/net/mgsx/gltf/scene3d/shaders/PBRShaderProvider.java b/gltf/src/net/mgsx/gltf/scene3d/shaders/PBRShaderProvider.java index 9baceab5..e0a7ba4c 100644 --- a/gltf/src/net/mgsx/gltf/scene3d/shaders/PBRShaderProvider.java +++ b/gltf/src/net/mgsx/gltf/scene3d/shaders/PBRShaderProvider.java @@ -122,7 +122,6 @@ protected boolean isGL3(){ * override this method in order to add your own prefix. * @param renderable * @param config - * @return */ public String createPrefixBase(Renderable renderable, PBRShaderConfig config) { @@ -370,7 +369,6 @@ protected Shader createShader(Renderable renderable) { * @param renderable * @param config * @param prefix - * @return */ protected PBRShader createShader(Renderable renderable, PBRShaderConfig config, String prefix){ return new PBRShader(renderable, config, prefix); diff --git a/gltf/src/net/mgsx/gltf/scene3d/utils/IBLBuilder.java b/gltf/src/net/mgsx/gltf/scene3d/utils/IBLBuilder.java index bca13bf4..1192466f 100644 --- a/gltf/src/net/mgsx/gltf/scene3d/utils/IBLBuilder.java +++ b/gltf/src/net/mgsx/gltf/scene3d/utils/IBLBuilder.java @@ -174,7 +174,7 @@ protected void disposeColorTexture(Cubemap colorTexture) { /** * Creates an radiance map, to be used with {@link net.mgsx.gltf.scene3d.attributes.PBRCubemapAttribute#SpecularEnv} * generated cubemap contains mipmaps in order to perform roughness in PBR shading - * @param levels mipMapLevels how many mipmaps level, eg. 10 levels produce a 1024x1024 cubemap with mipmaps. + * @param mipMapLevels how many mipmaps level, eg. 10 levels produce a 1024x1024 cubemap with mipmaps. * @return generated cubemap, caller is responsible to dispose it when no longer used. */ public Cubemap buildRadianceMap(final int mipMapLevels){