Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GLTFLoaderBase shouldn't be disposable #83

Open
mgsx-dev opened this issue Oct 24, 2022 · 1 comment
Open

GLTFLoaderBase shouldn't be disposable #83

mgsx-dev opened this issue Oct 24, 2022 · 1 comment
Assignees
Milestone

Comments

@mgsx-dev
Copy link
Owner

It may be "disposed" when an error occurring in order to prevent memory leaks. Some game/application may want to try to load a model and handle exception without crashing.

However it could be misleading: some people might think that they should dispose the loader. It shouldn't implement Disposable interface and dispose method should be protected and renamed as "cleanup" instead.

@mgsx-dev mgsx-dev added this to the 3.0 milestone Oct 24, 2022
@mgsx-dev mgsx-dev self-assigned this Oct 24, 2022
@prineside
Copy link

prineside commented Feb 7, 2023

Totally agree. Also have spent too much time trying to re-use the loaders (and they have managed to load 50 out of 217 GLTF 2.0 sample models somehow) because Disposable is usually used for something heavy / reusable such as Texture / Batch in LibGDX.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants