Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't update antd for broken antd es imports #588

Open
2 of 4 tasks
fredmaggiowski opened this issue Aug 27, 2024 · 1 comment
Open
2 of 4 tasks

Can't update antd for broken antd es imports #588

fredmaggiowski opened this issue Aug 27, 2024 · 1 comment
Labels
Breadcrumb component Breadcrumb component and hooks related activities bug Something isn't working FeedbackMessage component FeedbackMessage component and hooks related activities Menu component Menu component and hooks related activities Table component Table component and hooks related activities

Comments

@fredmaggiowski
Copy link
Member

fredmaggiowski commented Aug 27, 2024

The feature or bug you are proposing

In several components there are antd/es imports that breaks antd update.

Such imports are not part of the public interface and therefore subject to breaking changes, they must not be imported

Here search result: https://github.com/search?q=repo%3Amia-platform%2Fdesign-system%20%27antd%2Fes%2F&type=code

Affected components are

@fredmaggiowski fredmaggiowski added bug Something isn't working Table component Table component and hooks related activities FeedbackMessage component FeedbackMessage component and hooks related activities Menu component Menu component and hooks related activities Breadcrumb component Breadcrumb component and hooks related activities labels Aug 27, 2024
@Danielecina
Copy link
Member

We need to add a new rule in the ts lint to avoid using the import of nested or unexported dependencies.
If the library does not export types, we need to open a pr for them or implement a temporary custom type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breadcrumb component Breadcrumb component and hooks related activities bug Something isn't working FeedbackMessage component FeedbackMessage component and hooks related activities Menu component Menu component and hooks related activities Table component Table component and hooks related activities
Projects
None yet
Development

No branches or pull requests

2 participants