You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Some of the function types say that they'll return a string, but in fact often return undefined.
For example, if you use getAlpha2Code("Laos", "en"), then in fact you get undefined, not the stated string return type, because you were supposed to type Lao People's Democratic Republic (the fact that Laos doesn't match is a separate issue).
I'm willing to make a PR that makes these types more accurate to the true behavior of the library, but want to make sure that maintainers are OK with that change first.
The text was updated successfully, but these errors were encountered:
Some of the function types say that they'll return a string, but in fact often return
undefined
.For example, if you use
getAlpha2Code("Laos", "en")
, then in fact you getundefined
, not the statedstring
return type, because you were supposed to typeLao People's Democratic Republic
(the fact thatLaos
doesn't match is a separate issue).I'm willing to make a PR that makes these types more accurate to the true behavior of the library, but want to make sure that maintainers are OK with that change first.
The text was updated successfully, but these errors were encountered: