-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Require Base URL & handle parser errors #10
base: next
Are you sure you want to change the base?
Conversation
I see that this bumped some dependencies (nice!) and with that even brought in some completely new dependencies (ugh). These seem to be busboy and streamsearch, both being downstream from undici. Node 18 bundles undici (check The only thing undici seems to be doing for us right now is allow the configuration of On another note: could we add Prettier to the |
7d29d03
to
7fc2518
Compare
@Zegnat thanks for this, lots to do! For now, I've done the following:
|
Same here, hence why |
Nice! 👏 I had not heard about lint-staged. Probably going to have a look at that later. Though I am not a big fan of things that depend on git hooks (like husky). In general I believe the types of things people most often run in hooks to actually belong within CI. |
dc56b6c
to
ee870c3
Compare
Normally I would have both CI & Git hooks (always annoying to commit & push and for CI to fail for something that could have been auto-fixed in a pre-commit hook)... But, given how bare-bones this repo is at the moment, I've modified it to just be a GitHub action check, limited to only prettier. I do plan on adding some simple tests, so this can be extended. I would be keen - for now - not to add anymore to this PR, and perhaps to improve this app in the near future. |
Fixed #9.
Also does the following:
microformats-parser
microformats-parser
tov1.5.2
.nvmrc
for anyone using a node version managerprettier
with a corresponding GitHub actionundici
with the nativefetch
implementation.