Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align operation name of MP rest client spans with server-side JAX-RS #149

Open
pavolloffay opened this issue Apr 15, 2019 · 1 comment
Open

Comments

@pavolloffay
Copy link
Contributor

At the moment the operation name of rest client spans are HTTP verbs. However in the client filter we have access to the Method (org.eclipse.microprofile.rest.client.invokedMethod) which is being invoked so we have access to path annotation and also FQCN. Based on this data we can use the same operation names as on server side:

  • class-method - the provider for the default operation name.
  • http-path - the operation name has the following form <HTTP method>:<@Path value of endpoint’s class>/<@Path value of endpoint’s method>. For example if the class is annotated with @Path("service") and method @Path("endpoint/{id: \\d+}") then the operation name is GET:/service/endpoint/{id: \\d+}.
@pavolloffay pavolloffay changed the title Align operation name of rest client spans with server-side JAX-RS Align operation name of MP rest client spans with server-side JAX-RS Apr 16, 2019
@pavolloffay pavolloffay added this to the 1.4 milestone Apr 17, 2019
@pavolloffay
Copy link
Contributor Author

@fmhwong promised to implement this one.

@pavolloffay pavolloffay removed this from the 1.4 milestone Feb 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant