Skip to content
This repository has been archived by the owner on Jul 26, 2024. It is now read-only.

Use ImageTransport::advertiseCamera() #76

Open
shuntaraw opened this issue Sep 18, 2019 · 1 comment
Open

Use ImageTransport::advertiseCamera() #76

shuntaraw opened this issue Sep 18, 2019 · 1 comment
Labels
enhancement New feature or request ROS1 triage approved The Issue has been reviewed and approved for development by the Azure Kinect ROS Driver Team

Comments

@shuntaraw
Copy link
Contributor

shuntaraw commented Sep 18, 2019 •
edited
Loading

Is your feature request related to a problem? Please describe.
This is a proposal of a minor refactoring to clean up code.

Describe the solution you'd like
Replace the pairs of ImageTransport::advertise<Image>() and NodeHandle::advertise<CameraInfo>() in k4a_ros_device.cc with single calls to ImageTransport::advertiseCamera(). If there is a technical reason not to do this, please clarify it in the code comment.
@shuntaraw shuntaraw added enhancement New feature or request triage needed The Issue still needs to be reviewed by the Azure Kinect ROS Driver Team labels Sep 18, 2019
@shuntaraw shuntaraw changed the title Use ImageTransport::advertiseCamera() instead of the combination of ImageTransport::advertise<Image>() and NodeHandle::advertise<CameraInfo>() Use ImageTransport::advertiseCamera() Sep 18, 2019
@skalldri skalldri added triage approved The Issue has been reviewed and approved for development by the Azure Kinect ROS Driver Team and removed triage needed The Issue still needs to be reviewed by the Azure Kinect ROS Driver Team labels Sep 30, 2019
@ooeygui ooeygui added the ROS1 label Apr 19, 2022
@ooeygui
Copy link
Member

ooeygui commented Apr 19, 2022

This has not been implemented yet.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement New feature or request ROS1 triage approved The Issue has been reviewed and approved for development by the Azure Kinect ROS Driver Team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@skalldri @ooeygui @shuntaraw