Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DDS Async Summarization #7934

Closed
Tracked by #7615
scarlettjlee opened this issue Oct 21, 2021 · 0 comments · Fixed by #8592
Closed
Tracked by #7615

DDS Async Summarization #7934

scarlettjlee opened this issue Oct 21, 2021 · 0 comments · Fixed by #8592
Assignees
Milestone

Comments

@scarlettjlee
Copy link
Contributor

Work Item

Completion of #7615 <- see here for full details

Approach
The required work for this item is to break the graph visitation into two passes. The first pass visits the IChannels, instructing the channel to capture whatever state it will need in order to summarize itself. Because attachment occurs on the user's client (vs. the designated summarization client), this pass must remain synchronous to avoid local mutations while the snapshot is being captured.

The second pass revisits the same graph of IChannels, requesting that they produce an ISummaryTree from their previously captured state. This second pass is asynchronous, which allows allows the DDS implementer to upload or download blobs, and/or periodically yield.

What the DDS captures during the first pass is up to the DDS. DDSes using functional/persistent/immutable data structures may perform a cheap clone during this phase, while other DDSes may continue to synchronously produce an ITree in the first pass and simply return it in the second pass.

@scarlettjlee scarlettjlee added this to the November 2021 milestone Oct 21, 2021
@scarlettjlee scarlettjlee self-assigned this Oct 21, 2021
@scarlettjlee scarlettjlee changed the title Async Summarization (November) DDS Async Summarization (November) Oct 26, 2021
@scarlettjlee scarlettjlee changed the title DDS Async Summarization (November) DDS Async Summarization (Nov-Dec) Dec 6, 2021
@scarlettjlee scarlettjlee linked a pull request Dec 9, 2021 that will close this issue
@scarlettjlee scarlettjlee linked a pull request Jan 3, 2022 that will close this issue
@scarlettjlee scarlettjlee changed the title DDS Async Summarization (Nov-Dec) DDS Async Summarization Jan 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants