Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The _package_onnxruntime_runtime_dependencies function needs be updated #1538

Open
snnn opened this issue Jan 7, 2025 · 2 comments
Open

Comments

@snnn
Copy link
Member

snnn commented Jan 7, 2025

Describe the bug
The _package_onnxruntime_runtime_dependencies function in packaging_generator.py needs be updated. Now it uses package name to determine if the ORT package is a nightly package. However, in last Oct. the ONNX Runtime changed how nightly packages were named. Now both nightly packages and release packages have the same package name, but their versions are different.

To Reproduce
N/A

Expected behavior
The _package_onnxruntime_runtime_dependencies function needs to be updated to use package version to determine is_nightly or not.

Olive config
N/A

Olive logs
N/A

Other information

Additional context

@snnn
Copy link
Member Author

snnn commented Jan 7, 2025

Also, the package names in .azure_pipelines/olive-ort-nightly.yaml.

@jambayk
Copy link
Contributor

jambayk commented Jan 8, 2025

@xiaoyu-work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants