Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug in VS 17.10 #8138

Open
AdamYoblick opened this issue Jan 14, 2025 · 6 comments
Open

Fix bug in VS 17.10 #8138

AdamYoblick opened this issue Jan 14, 2025 · 6 comments
Assignees
@AdamYoblick

Comments

@AdamYoblick
Copy link
Member

AdamYoblick commented Jan 14, 2025 •
edited
Loading

Blocked by #8149

We have a bug that we fixed in VS 17.12 that also needs to be fixed in 17.10. The bug details are at https://msrceng.visualstudio.com/VulnReports/_workitems/edit/223894

The fix is in pylance, not PTVS, but since pylance is only consumed through PTVS, we need full PTVS insertions into VS to address this.

  1. Install those older versions of VS and verify the bug repros
  2. Figure out what PTVS commit made it into those branches, and snap them to their own release branches
  3. Figure out what versions of pylance made it into those PTVS versions, and snap them to their own release branches
  4. Hotfix the pylance versions and release new versions with the fix (release needs to be in the stable channel)
  5. Kick off builds from the new PTVS release branches, and manually specify the new corresponding pylance versions.
  6. Perform the VS insertion PR. Verify the bug is fixed using the PR build.
  7. Fill out a servicing bug for each.
@AdamYoblick AdamYoblick self-assigned this Jan 14, 2025
@AdamYoblick
Copy link
Member Author

Doc on installing older versions of VS is at https://dev.azure.com/devdiv/DevDiv/_wiki/wikis/DevDiv.wiki/623/Installing-Visual-Studio?anchor=installing-previous-releases

@AdamYoblick
Copy link
Member Author

AdamYoblick commented Jan 14, 2025 •
edited
Loading

For step 2 above, it's not trivial for old build numbers. You have to use the azdo REST API. I'm documenting how to do this at https://microsoft.sharepoint.com/teams/python/_layouts/15/Doc.aspx?sourcedoc={30d33826-9f98-4d3e-890e-b7d198bbbcbe}&action=edit&wd=target%28Python%20VS%2FDev%20Docs.one%7Cd7206ce2-cf40-437b-8ce9-1e55f4bc2f44%2FCreating%20a%20New%20Release%20Branch%7C2e67db82-efbb-4114-86a3-1e0d60bbd64e%2F%29&wdorigin=703

@AdamYoblick
Copy link
Member Author

AdamYoblick commented Jan 17, 2025 •
edited
Loading

This bug does not repro for 17.8, but it does repro for 17.10.

The PTVS build number for 17.10 is 24064.1. The commit for this build is b95d23a

The pylance version that shipped with 17.10 is 2024.2.2

@AdamYoblick AdamYoblick changed the title Fix bug in VS 17.8 and 17.10 Fix bug in VS 17.10 Jan 17, 2025
@AdamYoblick AdamYoblick mentioned this issue Jan 27, 2025
Closed
@AdamYoblick
Copy link
Member Author

Kicked off build at https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=10926685&view=results with package version set to 25023.4 which is one higher than what is in 17.10

@AdamYoblick
Copy link
Member Author

Release pipeline kicked off at https://dev.azure.com/devdiv/DevDiv/_build/results?buildId=10927183&view=results. Once it finishes and the insertion PR is created, I'll test with the build created by that PR.

@AdamYoblick
Copy link
Member Author

VS Insertion PR is at https://devdiv.visualstudio.com/DevDiv/_git/VS/pullrequest/607229?_a=overview

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AdamYoblick AdamYoblick

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rchiodo @AdamYoblick