Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the user to set the package version when running the azdo pipeline #8151

Merged
merged 5 commits into from
Jan 30, 2025

Conversation

AdamYoblick
Copy link
Member

@AdamYoblick AdamYoblick commented Jan 29, 2025

Fixes #8149

This allows the user to explicitly set the package version when running the azdo pipeline. Normally, using $(Build.BuildNumber) works just fine. But VS is strict about version relationships between their release branches, and we need to be able to patch the 17.10 branch with the new version still being lower than 17.11+ and also lower than main. Since the build numbers are always increasing, there isn't a way to do this currently.

So this change enables this functionality. The value will be set to the current build number if the user doesn't specify a version (the value can't be an empty string for runtime parameters unfortunately, so I set the default to currentBuildNumber. Otherwise, the value will be set to whatever the user specifies.

Testing

IN PROGRESS

  1. I ran our build pipeline, pointing at the set_package_version branch. That run is at https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=10920395&view=results. I left the PTVS package version as the default value of currentBuildNumber. Then I downloaded the bootstrapper from our build artifacts and ran it, installing the Python workload. I verified that the version in Help -> About matched the build number:

image
image

  1. I ran our build pipeline, pointing at the set_package_version branch. That run is at https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=10920896&view=results. I set the PTVS package version to 9999.99. Then I downloaded the bootstrapper from our build artifacts and ran it, installing the python workload. I verified that the version in Help -> About matched the version I set:

image
image

@AdamYoblick AdamYoblick requested a review from a team as a code owner January 29, 2025 19:35
@AdamYoblick
Copy link
Member Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@AdamYoblick AdamYoblick merged commit 9e5040e into main Jan 30, 2025
6 checks passed
@AdamYoblick AdamYoblick deleted the set_package_version branch January 30, 2025 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow VS package version to be explicitly set when running the build pipeline
2 participants