diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 8fdce2850..681693bc7 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -21,7 +21,7 @@ jobs: - name: Setup node uses: actions/setup-node@v4 with: - node-version: 16.x + node-version: 20.x - name: Install dependencies run: yarn install --immutable @@ -49,7 +49,7 @@ jobs: - name: Setup node uses: actions/setup-node@v4 with: - node-version: 16.x + node-version: 20.x - name: Install dependencies run: yarn install --immutable diff --git a/packages/ado-extension/src/ado-extension-metadata.spec.ts b/packages/ado-extension/src/ado-extension-metadata.spec.ts index 61ee2ffe0..6d118459c 100644 --- a/packages/ado-extension/src/ado-extension-metadata.spec.ts +++ b/packages/ado-extension/src/ado-extension-metadata.spec.ts @@ -76,12 +76,12 @@ describe(AdoExtensionMetadataProvider, () => { throw readFileError; }; - expect(() => testSubject.readMetadata()).toThrowError(readFileError); + expect(() => testSubject.readMetadata()).toThrow(readFileError); }); it('throws an error if ado-extension-metadata.json is malformatted', () => { mockFs.readFileSync = () => '{ "extensionName": "Oops it had some stray "quotes"" }'; - expect(() => testSubject.readMetadata()).toThrowError(/Unexpected token/); + expect(() => testSubject.readMetadata()).toThrow("Expected ',' or '}' after property value in JSON at position 44"); }); }); diff --git a/packages/ado-extension/task.json b/packages/ado-extension/task.json index 6eb234a3a..e628e5d5d 100644 --- a/packages/ado-extension/task.json +++ b/packages/ado-extension/task.json @@ -228,7 +228,7 @@ } ], "execution": { - "Node16": { + "Node20_1": { "target": "index.js" } }, diff --git a/pipelines/ado-extension-validation-template.yaml b/pipelines/ado-extension-validation-template.yaml index 34000ccf6..5e3d88bda 100644 --- a/pipelines/ado-extension-validation-template.yaml +++ b/pipelines/ado-extension-validation-template.yaml @@ -45,8 +45,8 @@ jobs: steps: - task: NodeTool@0 inputs: - versionSpec: '16.x' - displayName: Use Node 16.x + versionSpec: '20.x' + displayName: Use Node 20.x # reused by all "url" cases - script: npx serve "$(System.DefaultWorkingDirectory)/dev/website-root" -l 5858 & diff --git a/pipelines/build.yaml b/pipelines/build.yaml index ccc5a5e4d..48b604411 100644 --- a/pipelines/build.yaml +++ b/pipelines/build.yaml @@ -41,8 +41,8 @@ extends: steps: - task: NodeTool@0 inputs: - versionSpec: '16.x' - displayName: Use Node 16.x + versionSpec: '20.x' + displayName: Use Node 20.x - script: yarn install --immutable displayName: Install dependencies @@ -120,8 +120,8 @@ extends: steps: - task: NodeTool@0 inputs: - versionSpec: '16.x' - displayName: Use Node 16.x + versionSpec: '20.x' + displayName: Use Node 20.x - script: yarn install --immutable displayName: Install dependencies