Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fluent floating button style bugs #2112

Open
1 of 2 tasks
daceball opened this issue Jan 2, 2025 · 1 comment
Open
1 of 2 tasks

Fluent floating button style bugs #2112

daceball opened this issue Jan 2, 2025 · 1 comment

Comments

@daceball
Copy link

daceball commented Jan 2, 2025

Environment Information

  • Platform:
    • iOS
    • macOS

Please provide a reproduction of the bug:

The FluentButtonStyle(style: .floatingSubtle) style from the fluent library has some UI bugs.

Actual behavior:

The icon in the Floating fluent button style is not centered because of some padding added to the icon. Icon must be centered. The fluent icon shape is an oval, but it must be a circle. This is the expected UI design: https://www.figma.com/design/OLIFtMJnKfD4FGcnNq9TVo/Fluent-2-iOS?node-id=54882-225133&t=UMzRDU5cGJ4wAVxL-4

Expected behavior:

Icon must be centered, and button frame should be a circle.

Priorities and help requested:

Are you willing to submit a PR to fix? Yes, I am waiting for the expected design so that I can make the right updates.

Requested priority: Blocking

Image
@daceball
Copy link
Author

daceball commented Jan 3, 2025

I cloned the Fluent-iOS repository and ran the demo app. It seems the floating button with an icon-only design is correct there. This might mean that our app is using an older version of Fluent, or I might be unintentionally adding a text placeholder next to the icon, which could be triggering the icon + text design. I'll take a closer look!

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant