[rush-lib] Add override support for the PNPM virtual store directory #4987
+143
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iclanton
reviewed
Nov 1, 2024
| @@ -854,6 +854,11 @@ ${gitLfsHookHandling} | |||
| } | |||
| } | |||
|
|
|||
| // This will be overridden by RUSH_PNPM_VIRTUAL_STORE_PATH | |||
| if (EnvironmentConfiguration.pnpmVirtualStorePathOverride) { | |||
| args.push('--virtual-store-dir', this.rushConfiguration.pnpmOptions.pnpmVirtualStorePath); | |||
There was a problem hiding this comment.
Using a different approach than in RushPnpmCommandLineParser?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds the
RUSH_PNPM_VIRTUAL_STORE_PATHenvironment variable override to allow moving the PNPM virtual store directory. Fixes #4974.Details
After speaking with the creator of the bug, #4974 really was about removing the large number of dependency-related files from the RUSH_TEMP_FOLDER directory. Since we currently don't allow moving the RUSH_TEMP_FOLDER directory when using workspaces, this change continues with that approach and allows for moving the PNPM virtual store directory instead.
While it may be hypothetically possible to move the RUSH_TEMP_FOLDER directory, this is a more targeted change that accomplishes what the developer in the original issue was looking for.
How it was tested
[x] Added unit tests
[ ] Tested locally
Impacted documentation
Adds a new environment variable that likely will need to be documented on the Rushstack website.