Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accidental inclusion of public in ish jar #27

Closed
timothypratley opened this issue Dec 21, 2024 · 2 comments
Closed

Accidental inclusion of public in ish jar #27

timothypratley opened this issue Dec 21, 2024 · 2 comments

Comments

@timothypratley
Copy link

Is accidentally packages the "public" directory, which contains an implementation of ClojureScript:

Screenshot of contents of the ish jar:
Image

"public" is created by compilation, the library should only contain the source code.

I believe this could cause the wrong version of ClojureScript to be used by projects that depend on ish, but I don't have a repro case. At anyrate I believe these files were included by mistake, and it would be good to release a clean jar.

Related: https://groups.google.com/g/cursive/c/R0r1bTSrRBk

@emlyn
Copy link
Member

emlyn commented Feb 9, 2025

Thanks for the heads up (sorry for the late reply, I just saw the notification).
I've pushed version 0.1.7 without the extra files in there.

@timothypratley
Copy link
Author

Thank you! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants