You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In the Microsoft.Sbom.Targets NuGet package, the MSBuild properties UnzipGuid, ShortUnzipGuidFolder, and NugetPackageUnzip should preferably be renamed to something that includes "Sbom", to minimise the risk of conflicts with properties used for other purposes.
But I wonder how necessary a random number even is here. Perhaps the value of $(NugetPackageUnzip) could be just something like $(IntermediateOutputPath)sbom.tmp with no randomness at all. That change might make the unzipped files less likely to exceed the Windows PATH_MAX limit, too.
Chiming in as MSBuild PM to say that this is a good best practice since MSBuild lacks the concept of 'scope'. We've had cases in the past where multiple products used the same property in completely different ways and had unfortunate interactions as a result.
In the Microsoft.Sbom.Targets NuGet package, the MSBuild properties
UnzipGuid
,ShortUnzipGuidFolder
, andNugetPackageUnzip
should preferably be renamed to something that includes "Sbom", to minimise the risk of conflicts with properties used for other purposes.But I wonder how necessary a random number even is here. Perhaps the value of
$(NugetPackageUnzip)
could be just something like$(IntermediateOutputPath)sbom.tmp
with no randomness at all. That change might make the unzipped files less likely to exceed the Windows PATH_MAX limit, too.Originally posted by @KalleOlaviNiemitalo in #693 (comment)
The text was updated successfully, but these errors were encountered: