Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Microsoft.Sbom.Targets] Rename internal MSBuild properties to minimize risk of conflicts #800

Open
KalleOlaviNiemitalo opened this issue Nov 15, 2024 · 3 comments
Labels
help wanted Extra attention is needed .NET Pull requests that update .net code

Comments

@KalleOlaviNiemitalo
Copy link

In the Microsoft.Sbom.Targets NuGet package, the MSBuild properties UnzipGuid, ShortUnzipGuidFolder, and NugetPackageUnzip should preferably be renamed to something that includes "Sbom", to minimise the risk of conflicts with properties used for other purposes.

But I wonder how necessary a random number even is here. Perhaps the value of $(NugetPackageUnzip) could be just something like $(IntermediateOutputPath)sbom.tmp with no randomness at all. That change might make the unzipped files less likely to exceed the Windows PATH_MAX limit, too.

Originally posted by @KalleOlaviNiemitalo in #693 (comment)

@KalleOlaviNiemitalo
Copy link
Author

Guideline in dotnet/msbuild#2480 (comment)

@jalkire jalkire added the needs triage Default status upon issue submission label Nov 16, 2024
@baronfel
Copy link
Member

Chiming in as MSBuild PM to say that this is a good best practice since MSBuild lacks the concept of 'scope'. We've had cases in the past where multiple products used the same property in completely different ways and had unfortunate interactions as a result.

@jlperkins jlperkins added help wanted Extra attention is needed .NET Pull requests that update .net code and removed needs triage Default status upon issue submission labels Dec 5, 2024
@jlperkins
Copy link
Contributor

We would like to do this, but don't have capacity at the moment to do it ourselves. If you can provide a contribution, we would happily review it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed .NET Pull requests that update .net code
Projects
None yet
Development

No branches or pull requests

4 participants