Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📜scrollback search highlight 1️⃣ is incorrect, and 2️⃣ incorrectly snaps in response to STDOUT #18405

Open
ClaireCJS opened this issue Jan 6, 2025 · 2 comments
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting

Comments

@ClaireCJS
Copy link

Windows Terminal version

1.23.3232.0

Windows build number

10.0.19045.5247

Other Software

Steps to reproduce

  1. Hit Ctrl-Shift-F while a script is generating output

  2. Enter in something to search for. I suggest “e” for bug-finding purposes.

  3. Watch the highlights incorrectly dance around the screen.

  4. Fail to ever find your highlighted text as long as a script is running.

Expected Behavior

  1. The highlights to what I am searching for are only displayed on top of what I am searching for.

  2. If I am in search/scrollback mode and more STDOUT happens, it doesn’t snap me anywhere. (currently it snaps me all over the place)

Side-note: You know what else would be nice? A pause button that suspends the process temporarily. So we can go back and find our error message before it scrolls off-buffer.

Actual Behavior

Image

@ClaireCJS ClaireCJS added Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Jan 6, 2025
@ClaireCJS ClaireCJS changed the title scrollback search highlight is incorrect, 📜scrollback search highlight 1️⃣ is incorrect, and 2️⃣ incorrectly snaps in response to STDOUT Jan 6, 2025
@lhecker
Copy link
Member

lhecker commented Jan 6, 2025

Side-note: You know what else would be nice? A pause button that suspends the process temporarily. So we can go back and find our error message before it scrolls off-buffer.

Unless your current application has disabled processed input, you can either press the Pause button or Ctrl+S to achieve this.

@ClaireCJS
Copy link
Author

Side-note: You know what else would be nice? A pause button that suspends the process temporarily. So we can go back and find our error message before it scrolls off-buffer.

Unless your current application has disabled processed input, you can either press the Pause button or Ctrl+S to achieve this.

I actually intercept my pause key to pause the music. Thanks for the Ctrl-S tip! I thought that stuff only worked in the BBS days :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting
Projects
None yet
Development

No branches or pull requests

2 participants