Inconsistent gutters/margins on HiDPI displays with snapToGridOnResize

[DHowett-MSFT]

It looks like on my 200% scale device it's snapping at the half-grid.

---

A 50x15 window at 150% scale with Ctrl+Shift+A:

After resizing the window to 51x15:

[randomascii]

At 125% scaling it seems to have a variable padding at the bottom. As you size the window up from the bottom, one line at a time, it actually shrinks the window by some lesser amount - probably 80% of a line.

Even at 100% it is not totally reliable. When you expand the height of the window the newly revealed line will sometimes not render (even though there is content there) but if you scroll up and down the content will appear.

[MVS-99]

Is there a solution yet for this kind of issue??? Mostly appears when changing terminal from one screen to another.

[meshkinyar]

Is there a solution yet for this kind of issue??? Mostly appears when changing terminal from one screen to another.

A hacky solution I found is creating a PNG that is just filled with your set background color and then setting that to the background image of your current profile. No random padding (at least any that's visible anyway).

The space seems to be leftover padding for the scrollbars that just isn't cleaned due to display scaling. It's just strange that having an image background seems to hide this problem. My guess is that the problem is visible due to there being an unset "application background" that the terminal is rendered on top of when not set to an image. In my case it could also be an out-of-gamut accent color but I really don't know.

[zadjii-msft]

terminal/src/cascadia/TerminalControl/TermControl.cpp

Lines 2415 to 2433 in 636be7e

	float TermControl::SnapDimensionToGrid(const bool widthOrHeight, const float dimension)
	{
	const auto fontSize = _core.FontSize();
	const auto fontDimension = widthOrHeight ? fontSize.Width : fontSize.Height;
	const auto padding = GetPadding();
	auto nonTerminalArea = gsl::narrow_cast<float>(widthOrHeight ?
	padding.Left + padding.Right :
	padding.Top + padding.Bottom);
	if (widthOrHeight && _core.Settings().ScrollState() != ScrollbarState::Hidden)
	{
	nonTerminalArea += gsl::narrow_cast<float>(ScrollBar().ActualWidth());
	}
	const auto gridSize = dimension - nonTerminalArea;
	const auto cells = floor(gridSize / fontDimension);
	return cells * fontDimension + nonTerminalArea;
	}

Pretty sure this just doesn't account for DIPs vs pixels at all. Never has. I'd reckon that dimension is in DIPs and fontSize is in pixels. Someone could pretty easily fix that

[rp1231]

I'm having this problem as well on a 4k display.
Used a white background to show the borders.
Is there any way to totally get rid of the borders from all sides?

[MarcoBuess]

Seeing that this is open for almost a year, is this still being worked on? As it seems its still relevant. #17721 mentions 1.23 as a potential candidate that adresses this, am I understanding correctly?

[Ali-Nu]

No, it's not. вт, 7 янв. 2025 г., 14:53 Marco Bueß ***@***.***>:

…

Seeing that this is open for almost a year, is this still being worked on? As it seems its still relevant. #17721 <#17721> mentions 1.23 as a potential candidate that adresses this, am I understanding correctly? — Reply to this email directly, view it on GitHub <#4175 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BOAUGLPLZMNA4QO3ABKCRX32JOPZHAVCNFSM6AAAAABUXK5C66VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNZUHA2DKNBUGA> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>