Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the user to set the minimum window size #6820

Open
rdsecops opened this issue Jul 7, 2020 · 15 comments
Open

Allow the user to set the minimum window size #6820

rdsecops opened this issue Jul 7, 2020 · 15 comments
Labels
Area-Settings Issues related to settings and customizability, for console or terminal good first issue This is a fix that might be easier for someone to do as a first contribution Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Priority-3 A description (P3) Product-Terminal The new Windows Terminal.
Milestone

Comments

@rdsecops
Copy link

rdsecops commented Jul 7, 2020

Description of the new feature/enhancement

Create an option "disable window resizing" or "fixed minimum window size" in global settings.

Proposed technical implementation details (optional)

Window Resizing Settings

Property name: enableWindowResizing

Necessity: Optional

Accepts: true, false

Default value: true
_________________________ OR __________________________________

Fixed Minimum Window Size

Property name: minimumWindowSize

Necessity: Optional

Accepts: Dimensions - rows,columns

Default value: 30,120

@rdsecops rdsecops added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Jul 7, 2020
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jul 7, 2020
@zadjii-msft
Copy link
Member

... Why though? Since resizing is a user-initiated event, couldn't you just not resize the window?

@zadjii-msft zadjii-msft added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Jul 7, 2020
@rdsecops
Copy link
Author

rdsecops commented Jul 7, 2020

... Why though? Since resizing is a user-initiated event, couldn't you just not resize the window?

For aesthetic and comercial reasons. If I create a console app and compose it with a background image, like my company logo, resizing the window, in this case making it smaller, will make the composition less interesting, since the backgroung image is static. For this reason it would be better if I could keep the user from doing that.

@ghost ghost added Needs-Attention The core contributors need to come back around and look at this ASAP. and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Jul 7, 2020
@WSLUser
Copy link
Contributor

WSLUser commented Jul 7, 2020

since the background image is static. For this reason it would be better if I could keep the user from doing that

I think the solution is make the background image dynamic instead. If I want to resize then I'm going to regardless if a background image is static. Attempting to force your users to do things your way is how you lose users. It's all about choice and Windows Terminal is great about doing that and is adding even more for that.

@rdsecops
Copy link
Author

rdsecops commented Jul 7, 2020

since the background image is static. For this reason it would be better if I could keep the user from doing that

I think the solution is make the background image dynamic instead. If I want to resize then I'm going to regardless if a background image is static. Attempting to force your users to do things your way is how you lose users. It's all about choice and Windows Terminal is great about doing that and is adding even more for that.

It would be nice to make the background image dynamic, but I think bitmap formats like png are not the best choice for this. If introducing an option to prevent resizing is such a big problem, an option for a fixed minimum size would do the job.

I'm proposing something based on my needs and maybe somebody else's needs. My users are from an IT niche and Windows Terminal is giving me the oportunity improve apps that we already have and create even better ones. But, a "disable window resizing" option or a "fixed minimum window size" option would really be helpful for what I pretend to do.

@WSLUser
Copy link
Contributor

WSLUser commented Jul 7, 2020

There's already a minimum window size set you can't go any smaller with though it could use a bit more work (I can make it so everything but the tab is visible, there should at least be one visible line you can type into). I would be in favor of allowing a setting to be added for this instead of removing the ability to resize and defaulting it to true, something that would break more users than your niche crowd consists of.

@rdsecops
Copy link
Author

rdsecops commented Jul 7, 2020

There's already a minimum window size set you can't go any smaller with though it could use a bit more work (I can make it so everything but the tab is visible, there should at least be one visible line you can type into). I would be in favor of allowing a setting to be added for this instead of removing the ability to resize and defaulting it to true, something that would break more users than your niche crowd consists of.

A fixed minimum window size would be great. It would be really helpful.

@buanzo
Copy link

buanzo commented Jul 8, 2020

Some mice have issues triggering excessive events after a scroll. Windows resizing gets triggered without the user meaning to. I prefer terminal resizing to be bound to keyboard shortcuts such as those used in browsers, and the ability to disable mouse-initiated resizing.

@rdsecops
Copy link
Author

rdsecops commented Jul 8, 2020

Some mice have issues triggering excessive events after a scroll. Windows resizing gets triggered without the user meaning to. I prefer terminal resizing to be bound to keyboard shortcuts such as those used in browsers, and the ability to disable mouse-initiated resizing.

I've opened an issue-feature about that too, but the developers/contributors are aware and already working on it.

@zadjii-msft
Copy link
Member

zadjii-msft commented Jul 16, 2020

I'm okay with letting the user configure the minimum window size, so I'll re-purpose this thread accordingly. Thanks for the discussion all!

To add:
The minmum window size is currently set in pixels. If we do add a setting for this, should it be in "cols,rows" format, or "width in pixels, height in pixels" format? I'm leaning towards the pixels one personally.

We'll also need to make sure that it's optional, and it can't be set to smaller than what the value we're currently using is.

@zadjii-msft zadjii-msft added Area-Settings Issues related to settings and customizability, for console or terminal good first issue This is a fix that might be easier for someone to do as a first contribution Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. and removed Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Needs-Attention The core contributors need to come back around and look at this ASAP. labels Jul 16, 2020
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Jul 16, 2020
@zadjii-msft zadjii-msft added this to the Terminal Backlog milestone Jul 16, 2020
@zadjii-msft zadjii-msft changed the title Disable Window Resizing Allow the user to set the minimum window size Jul 16, 2020
@DHowett DHowett added Priority-3 A description (P3) and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Jul 16, 2020
@Don-Vito
Copy link
Contributor

@zadjii-msft - once we merge #8066 this might be quite straightforward. WDYT?

@zadjii-msft zadjii-msft added this to the Backlog milestone Jan 4, 2022
@zadjii-msft zadjii-msft moved this to Should be written in Terminal Walkthroughs Feb 6, 2023
@akoolarni
Copy link

is this issue open ?

@DHowett
Copy link
Member

DHowett commented Sep 12, 2023

is this issue open ?

image

It appears to be!

@edward-jazzhands
Copy link

Why was this never implemented? This is an extremely easy to build feature, and from what I can tell the only reason it was never implemented was because of a few people trying to wrongly claim it's "not necessary", even though there's numerous people saying they want this feature.

@zadjii-msft
Copy link
Member

We'd be more than happy to accept a contribution of this extremely easy to build feature! As it stands there are more than 175 issues with more 👍's than this thread, so it's pretty far down our own backlog. But I agree, it would be fairly easy for someone passionate about this to add it ☺

@Gregory-K
Copy link

@zadjii-msft

We'll also need to make sure that it's optional, and it can't be set to smaller than what the value we're currently using is.

Could this hardcoded minimum width value drop to just protecting the essential control buttons - [] x or at least something around 260-320px?

I know, it appears odd, but I sometimes use a grid of 260px/320px.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Settings Issues related to settings and customizability, for console or terminal good first issue This is a fix that might be easier for someone to do as a first contribution Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Priority-3 A description (P3) Product-Terminal The new Windows Terminal.
Projects
Status: Should be written
Development

No branches or pull requests

9 participants