-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Add JFrog V2 Service Endpoint Data Source (Issue #1231) #1232
base: main
Are you sure you want to change the base?
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jasonouellet Except for the properties used to retrieve resource, other properties should marked with compute=true
in the scheme. You can take data_serviceendpoint_azurecr example. I only commented data_serviceendpoint_jfrog_artifactory_v2.go
, all the resources needs to be updated.
Once those are fixed up I can take another look.
azuredevops/internal/service/serviceendpoint/data_serviceendpoint_jfrog_artifactory_v2.go
Outdated
Show resolved
Hide resolved
azuredevops/internal/service/serviceendpoint/data_serviceendpoint_jfrog_artifactory_v2.go
Outdated
Show resolved
Hide resolved
azuredevops/internal/service/serviceendpoint/data_serviceendpoint_jfrog_artifactory_v2.go
Outdated
Show resolved
Hide resolved
azuredevops/internal/service/serviceendpoint/data_serviceendpoint_jfrog_artifactory_v2.go
Outdated
Show resolved
Hide resolved
azuredevops/internal/service/serviceendpoint/data_serviceendpoint_jfrog_artifactory_v2.go
Outdated
Show resolved
Hide resolved
azuredevops/internal/service/serviceendpoint/data_serviceendpoint_jfrog_artifactory_v2.go
Outdated
Show resolved
Hide resolved
azuredevops/internal/service/serviceendpoint/data_serviceendpoint_jfrog_distribution_v2.go
Outdated
Show resolved
Hide resolved
azuredevops/internal/service/serviceendpoint/data_serviceendpoint_jfrog_platform_v2.go
Outdated
Show resolved
Hide resolved
azuredevops/internal/service/serviceendpoint/data_serviceendpoint_jfrog_xray_v2.go
Outdated
Show resolved
Hide resolved
azuredevops/internal/service/serviceendpoint/data_serviceendpoint_jfrog_distribution_v2.go
Outdated
Show resolved
Hide resolved
azuredevops/internal/service/serviceendpoint/data_serviceendpoint_jfrog_xray_v2.go
Outdated
Show resolved
Hide resolved
website/docs/d/serviceendpoint_jfrog_artifactory_v2.html.markdown
Outdated
Show resolved
Hide resolved
…int_jfrog_distribution_v2.go Co-authored-by: xuzhang3 <[email protected]>
…int_jfrog_artifactory_v2.go Co-authored-by: xuzhang3 <[email protected]>
…int_jfrog_platform_v2.go Co-authored-by: xuzhang3 <[email protected]>
…int_jfrog_distribution_v2.go Co-authored-by: xuzhang3 <[email protected]>
…int_jfrog_xray_v2.go Co-authored-by: xuzhang3 <[email protected]>
…int_jfrog_xray_v2.go Co-authored-by: xuzhang3 <[email protected]>
Co-authored-by: xuzhang3 <[email protected]>
Co-authored-by: xuzhang3 <[email protected]>
Co-authored-by: xuzhang3 <[email protected]>
Co-authored-by: xuzhang3 <[email protected]>
7d7ad6d
to
b8fcc20
Compare
…int_jfrog_artifactory_v2.go Co-authored-by: xuzhang3 <[email protected]>
…int_jfrog_platform_v2.go Co-authored-by: xuzhang3 <[email protected]>
All Submissions:
What about the current behavior has changed?
Issue Number: #1231
Ading data source:
Does this introduce a change to
go.mod
,go.sum
orvendor/
?Does this introduce a breaking change?
Any relevant logs, error output, etc?
(If it’s long, please paste to https://ghostbin.com/ and insert the link here.)
Other information