-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nightly Build Failure 2024-09-21 #178
Comments
cc @microsoft/aifx-compilers |
cc @microsoft/aifx-compilers |
cc @microsoft/aifx-compilers |
cc @microsoft/aifx-compilers |
cc @microsoft/aifx-compilers |
cc @microsoft/aifx-compilers |
cc @microsoft/aifx-compilers |
cc @microsoft/aifx-compilers |
cc @microsoft/aifx-compilers |
cc @microsoft/aifx-compilers |
cc @microsoft/aifx-compilers |
cc @microsoft/aifx-compilers |
cc @microsoft/aifx-compilers |
cc @microsoft/aifx-compilers |
cc @microsoft/aifx-compilers |
cc @microsoft/aifx-compilers |
cc @microsoft/aifx-compilers |
cc @microsoft/aifx-compilers |
cc @microsoft/aifx-compilers |
cc @microsoft/aifx-compilers |
cc @microsoft/aifx-compilers |
cc @microsoft/aifx-compilers |
cc @microsoft/aifx-compilers |
cc @microsoft/aifx-compilers |
cc @microsoft/aifx-compilers |
cc @microsoft/aifx-compilers |
cc @microsoft/aifx-compilers |
We're prioritizing some feature work, so updating triton-shared to work with the latest triton will be less of a priority. |
cc @microsoft/aifx-compilers |
cc @microsoft/aifx-compilers |
cc @microsoft/aifx-compilers |
cc @microsoft/aifx-compilers |
cc @microsoft/aifx-compilers |
cc @microsoft/aifx-compilers |
Fixing below compilation errors in include/triton-shared/Conversion/TritonArithToLinalg/ConversionPatterns.hpp: /home/runner/work/triton-shared/triton-shared/triton_shared/include/triton-shared/Conversion/TritonArithToLinalg/ConversionPatterns.hpp:839:68: error: no member named 'getFile' in 'mlir::triton::AssertOp' llvm::formatv("{0}.py:{1}: {2} Assertion `{3}` failed", op.getFile(), ~~ ^ /home/runner/work/triton-shared/triton-shared/triton_shared/include/triton-shared/Conversion/TritonArithToLinalg/ConversionPatterns.hpp:840:26: error: no member named 'getLine' in 'mlir::triton::AssertOp' op.getLine(), op.getFunc(), op.getMessage()); ~~ ^ /home/runner/work/triton-shared/triton-shared/triton_shared/include/triton-shared/Conversion/TritonArithToLinalg/ConversionPatterns.hpp:840:40: error: no member named 'getFunc' in 'mlir::triton::AssertOp' op.getLine(), op.getFunc(), op.getMessage()); ~~ ^ 3 errors generated. This fix builds with triton @ab07e5472bcb414a0c8dd7ecab80f84370c4894e, and llvm @cfd3289a1f9a87e220737a634904a886a82d424a.
Fix compilation errors caused by LLVM commits: f18c3e4e7335df282c468b6dff3d29be1822a96d [mlir][Transforms] Dialect Conversion: Simplify materialization fn result type (#113031) 8c4bc1e75de27adfbaead34b895b0efbaf17bd02 [mlir][Transforms] Merge 1:1 and 1:N type converters (#113032) Update Triton to 94684d326723b67b146f23f342623ea058a32098
cc @microsoft/aifx-compilers |
cc @microsoft/aifx-compilers |
cc @microsoft/aifx-compilers |
cc @microsoft/aifx-compilers |
cc @microsoft/aifx-compilers |
cc @microsoft/aifx-compilers |
cc @microsoft/aifx-compilers |
cc @microsoft/aifx-compilers |
cc @microsoft/aifx-compilers |
cc @microsoft/aifx-compilers |
Fixing below compilation errors in include/triton-shared/Conversion/TritonArithToLinalg/ConversionPatterns.hpp: /home/runner/work/triton-shared/triton-shared/triton_shared/include/triton-shared/Conversion/TritonArithToLinalg/ConversionPatterns.hpp:839:68: error: no member named 'getFile' in 'mlir::triton::AssertOp' llvm::formatv("{0}.py:{1}: {2} Assertion `{3}` failed", op.getFile(), ~~ ^ /home/runner/work/triton-shared/triton-shared/triton_shared/include/triton-shared/Conversion/TritonArithToLinalg/ConversionPatterns.hpp:840:26: error: no member named 'getLine' in 'mlir::triton::AssertOp' op.getLine(), op.getFunc(), op.getMessage()); ~~ ^ /home/runner/work/triton-shared/triton-shared/triton_shared/include/triton-shared/Conversion/TritonArithToLinalg/ConversionPatterns.hpp:840:40: error: no member named 'getFunc' in 'mlir::triton::AssertOp' op.getLine(), op.getFunc(), op.getMessage()); ~~ ^ 3 errors generated. This fix builds with triton @ab07e5472bcb414a0c8dd7ecab80f84370c4894e, and llvm @cfd3289a1f9a87e220737a634904a886a82d424a. --------- Co-authored-by: Zhaoshi Zheng <[email protected]>
cc @microsoft/aifx-compilers |
cc @microsoft/aifx-compilers |
seems the nightly build is checkout Triton main after git submodule, pushed a fix: #223 |
I was thinking this is on purpose |
@zhaoshiz Thanks for your PR. This is on purpose though -- it lets us know that we need to fix triton-shared to work with triton upstream. Basically, every night, we would run triton-shared with the latest triton. If it fails, an issue is created. From the newest logs, it looks like upstream triton just updated llvm which renamed some methods. |
I see, thanks for clarifying that. I tried building with latest Triton locally, there's more than just LLVM API change needed. I got a link error about I'll try to resolve them. |
cc @microsoft/aifx-compilers |
I managed to figure out and updated #223 |
cc @microsoft/aifx-compilers |
cc @microsoft/aifx-compilers |
cc @microsoft/aifx-compilers |
cc @microsoft/aifx-compilers
The nightly build has failed. See: https://github.com/microsoft/triton-shared/actions/runs/10971860915
The text was updated successfully, but these errors were encountered: