Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request] recognize docker-compose.<something>.yml files #261

Closed
waspinator opened this issue May 8, 2018 · 9 comments
Closed

Comments

@waspinator
Copy link

waspinator commented May 8, 2018

Docker compose has an option to override files for use in different situations. A common pattern seems to be to append a .<something> to a docker-compose file. Could we add recognition of those type of files?

https://docs.docker.com/compose/extends/#example-use-case

@chrisdias
Copy link
Member

what are you thinking about when you say "recognition"? According to the docs, a docker-compose.override.yml will automatically be picked up. If you have another file then you have to pass them to docker-compose with multiple -f parameters. There is no way to easily specify the order of files in VS Code. I could have a multiple pick list, but there is no explicit order with that.

tell me more what you would like to see... thx.

@waspinator
Copy link
Author

waspinator commented May 9, 2018

It's not a big deal I know, but I'd like to see a pink whale instead of an exclamation mark as the file icon. I'm not sure if any actual linting is happening to the docker-compose file, but if it is, having the whale icon gives me more confidence that vscode knows what kind of file it is.

icon example

@robertpeteuil
Copy link

This is related to a request I made in January in #206

@AArnott
Copy link
Member

AArnott commented Jun 20, 2018

@chrisdias As #223 describes, the docker-compose.override.yml file will only be automatically picked up if no -f switch is specified. This VS Code Docker extension's UI forces us to specify exactly one yml file, which turns into a -f switch. This means no file is automatically picked up, and no single file has the right content for local development, since local development is facilitated by docker-compose.yml and docker-compose.override.yml combined.

@PrashanthCorp
Copy link
Contributor

@AArnott, it looks like the -f switch is specified by default. See here.

Would the gist of your request be that this flag be made optional?

@PrashanthCorp PrashanthCorp self-assigned this Aug 13, 2018
@AArnott
Copy link
Member

AArnott commented Aug 13, 2018

Yes.

@StephenWeatherford
Copy link
Contributor

@PrashanthCorp Please pull last issue into a separate bug.

@StephenWeatherford
Copy link
Contributor

Should enter an issue against vscode.

@bwateratmsft
Copy link
Collaborator

Marking this one as a dupe of #379 and #520

@bwateratmsft bwateratmsft added duplicate and removed P2 labels Oct 21, 2019
@bwateratmsft bwateratmsft removed this from the 0.10.0 milestone Nov 4, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

9 participants