Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot load extension with 'natives' as an indirect dependency #1404

Closed
brettcannon opened this issue Apr 16, 2018 · 1 comment · Fixed by #1419
Closed

Cannot load extension with 'natives' as an indirect dependency #1404

brettcannon opened this issue Apr 16, 2018 · 1 comment · Fixed by #1419
Assignees
@MikhailArkhipov
Labels
bug Issue identified by VS Code Team member as probable bug
Milestone
April 2018

Comments

@brettcannon
Copy link
Member

Due to https://go.microsoft.com/fwlink/?linkid=871887 you can no longer load an extension that pulls in the native package. Unfortunately, it looks like unzip pulls it in according to npm ls natives:

`-- [email protected]
  `-- [email protected]
    `-- [email protected]
      `-- [email protected]

We got that dependency as part of #1231.
@brettcannon brettcannon added bug Issue identified by VS Code Team member as probable bug needs PR labels Apr 16, 2018
@brettcannon brettcannon added this to the April 2018 milestone Apr 16, 2018
@MikhailArkhipov
Copy link

EvanOxfeld/node-unzip#115

@MikhailArkhipov MikhailArkhipov mentioned this issue Apr 17, 2018
Merged
3 tasks
@lock lock bot locked as resolved and limited conversation to collaborators Jul 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@MikhailArkhipov MikhailArkhipov

Labels
bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Milestone
April 2018
Development

Successfully merging a pull request may close this issue.

Replace unzip package
2 participants
@brettcannon @MikhailArkhipov