Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New terminal editors created on "reload window" #127627

Closed
weinand opened this issue Jun 30, 2021 · 1 comment
Closed

New terminal editors created on "reload window" #127627

weinand opened this issue Jun 30, 2021 · 1 comment
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal General terminal issues that don't fall under another label terminal-editors verified Verification succeeded
Milestone

Comments

@weinand
Copy link
Contributor

weinand commented Jun 30, 2021

Testing #127192

  • make sure to have a terminal open in the panel
  • set setting "terminal.integrated.defaultLocation" to "editor"
  • run command "reload window"

Observe:
another terminal opens in the editor group

@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug terminal General terminal issues that don't fall under another label terminal-editors labels Jun 30, 2021
@Tyriar Tyriar added this to the June 2021 milestone Jun 30, 2021
@Tyriar
Copy link
Member

Tyriar commented Jun 30, 2021

This is actually the reconnected terminal in the panel is being created in the editor, then a new one is created because the panel is open.

@Tyriar Tyriar closed this as completed in 1d3a7b6 Jun 30, 2021
@rzhao271 rzhao271 added the verified Verification succeeded label Jul 1, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Aug 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal General terminal issues that don't fall under another label terminal-editors verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

5 participants
@weinand @Tyriar @rzhao271 @meganrogge and others