Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terminal renders during process reconnect (aka. replay) #127638

Closed
lszomoru opened this issue Jun 30, 2021 · 2 comments · Fixed by #129207
Closed

Terminal renders during process reconnect (aka. replay) #127638

lszomoru opened this issue Jun 30, 2021 · 2 comments · Fixed by #129207
Assignees
@Tyriar @meganrogge
Labels
insiders-released Patch has been released in VS Code Insiders polish Cleanup and polish issue terminal General terminal issues that don't fall under another label terminal-rendering
Milestone
Backlog

Comments

@lszomoru
Copy link
Member

Testing #127192

Screen.Recording.2021-06-30.at.13.34.04.mov
@Tyriar
Copy link
Member

Tyriar commented Jun 30, 2021

This is probably an existing issues, we could potentially attach to the element only after the replay is finished to avoid watching long writes happen.

@Tyriar Tyriar added polish Cleanup and polish issue terminal General terminal issues that don't fall under another label terminal-rendering labels Jun 30, 2021
@Tyriar Tyriar added this to the Backlog milestone Jun 30, 2021
@Tyriar
Copy link
Member

Tyriar commented Jul 22, 2021

Related to #116113, when I run tree the replay ends up taking about 300ms for a single terminal:

image

Renders may happen in-between this parsing which would cause flickers like above, this depends on the shape of the replay events.

@Tyriar Tyriar changed the title Test: Terminal editors - terminal content rendering on reload Terminal renders during process reconnect (aka. replay) Jul 22, 2021
@Tyriar Tyriar mentioned this issue Jul 23, 2021
Merged
14 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Sep 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

@meganrogge meganrogge

Labels
insiders-released Patch has been released in VS Code Insiders polish Cleanup and polish issue terminal General terminal issues that don't fall under another label terminal-rendering
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

xterm.js node target and serialize addon microsoft/vscode
4 participants
@Tyriar @lszomoru @meganrogge and others