Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better Highlighting of Find's Results in the Terminal #128014

Closed
justinfargnoli opened this issue Jul 5, 2021 · 1 comment
Closed

Better Highlighting of Find's Results in the Terminal #128014

justinfargnoli opened this issue Jul 5, 2021 · 1 comment
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s)

Comments

@justinfargnoli
Copy link

When using Find in the integrated Terminal it has been challenging for me to see what is being highlighted because it blends in with the text.

Here's an example:
Screen Shot 2021-07-05 at 1 49 46 PM
The highlighting isn't distinct enough to catch my eye. I often resort to shrinking the terminal to only display a few lines, so I can find the highlighted text faster.

It'd be helpful for me if there this was more distinct or if it caught your eye faster. For example, when using Find in Safari, Find will briefly and quickly enlarge the selected text and highlight it yellow to catch your eye.

@Tyriar
Copy link
Member

Tyriar commented Jul 6, 2021

/duplicate xtermjs/xterm.js#1653

@Tyriar Tyriar closed this as completed Jul 6, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Aug 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s)
Projects
None yet
Development

No branches or pull requests

4 participants
@Tyriar @meganrogge @justinfargnoli and others