Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terminal: Dropdown popup doesn't always work #143703

Closed
joaomoreno opened this issue Feb 23, 2022 · 2 comments
Closed

Terminal: Dropdown popup doesn't always work #143703

joaomoreno opened this issue Feb 23, 2022 · 2 comments
Assignees
@Tyriar
Labels
bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority terminal-shell-integration Shell integration infrastructure, command decorations, etc. verified Verification succeeded
Milestone
February 2022

Comments

@joaomoreno
Copy link
Member

Testing #143433

  1. Enable terminal.integrated.shellIntegration.enabled
  2. Run any command in the terminal
  3. Click the decoration, popup menu comes up
  4. Resize the terminal
  5. Click the decoration again

🐛 Popup menu doesn't come up
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug terminal-command-decoration labels Feb 23, 2022
@Tyriar Tyriar added this to the February 2022 milestone Feb 23, 2022
@Tyriar
Copy link
Member

Tyriar commented Feb 23, 2022

Can repro

Recording 2022-02-23 at 07 58 48

@meganrogge meganrogge mentioned this issue Feb 23, 2022
Closed
@Tyriar Tyriar mentioned this issue Feb 23, 2022
Closed
@Tyriar Tyriar added the important Issue identified as high-priority label Feb 23, 2022
@Tyriar
Copy link
Member

Tyriar commented Feb 23, 2022

Actually this appears to be fixed in main now, repro was easy in insiders and can no longer make it happen in oss.

@Tyriar Tyriar closed this as completed Feb 23, 2022
This was referenced Feb 24, 2022
Closed
Closed
@joyceerhl joyceerhl added the verified Verification succeeded label Feb 25, 2022
@Tyriar Tyriar added the terminal-shell-integration Shell integration infrastructure, command decorations, etc. label Feb 28, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Apr 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority terminal-shell-integration Shell integration infrastructure, command decorations, etc. verified Verification succeeded
Projects
None yet
Milestone
February 2022
Development

No branches or pull requests
4 participants
@joaomoreno @Tyriar @meganrogge @joyceerhl