Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hard to tell where navigation is on slower machines #145801

Closed
miguelsolorio opened this issue Mar 22, 2022 · 3 comments
Closed

Hard to tell where navigation is on slower machines #145801

miguelsolorio opened this issue Mar 22, 2022 · 3 comments
Assignees
@Tyriar @meganrogge
Labels
author-verification-requested Issues potentially verifiable by issue author bug Issue identified by VS Code Team member as probable bug on-release-notes Issue/pull request mentioned in release notes terminal-shell-integration Shell integration infrastructure, command decorations, etc. upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-fixed The underlying upstream issue has been fixed upstream-issue-linked This is an upstream issue that has been reported upstream verified Verification succeeded
Milestone
May 2022

Comments

@miguelsolorio
Copy link
Contributor

Testing #145627

When working on a machine that is slow/sluggish, it is impossible to tell where the navigation goes to because the line highlight fades away. I think having some type of subtle decoration on the line would help alleviate this issue for time based animations. The Terminal app shows a line:

CleanShot 2022-03-22 at 15 10 38@2x

Tried capturing this experience:

IMG_1973.mov
@meganrogge meganrogge added bug Issue identified by VS Code Team member as probable bug upstream Issue identified as 'upstream' component related (exists outside of VS Code) terminal-shell-integration Shell integration infrastructure, command decorations, etc. labels Mar 23, 2022
@meganrogge meganrogge added this to the April 2022 milestone Mar 23, 2022
@meganrogge meganrogge modified the milestones: April 2022, May 2022 Apr 25, 2022
@meganrogge meganrogge mentioned this issue May 12, 2022
Closed
@meganrogge meganrogge added upstream-issue-linked This is an upstream issue that has been reported upstream upstream-issue-fixed The underlying upstream issue has been fixed labels May 12, 2022
@Tyriar
Copy link
Member

Tyriar commented May 20, 2022

I think the xterm.js update happened for this

@Tyriar Tyriar closed this as completed May 20, 2022
@roblourens roblourens added verified Verification succeeded author-verification-requested Issues potentially verifiable by issue author and removed verified Verification succeeded labels Jun 3, 2022
@roblourens
Copy link
Member

Maybe you can verify this on the same machine @misolori

@meganrogge meganrogge added the on-release-notes Issue/pull request mentioned in release notes label Jun 3, 2022
@miguelsolorio miguelsolorio added the verified Verification succeeded label Jun 6, 2022
@miguelsolorio
Copy link
Contributor Author

Verified that this is now much improved as the line only appears when you are scrolled to the next anchor point 👏

@github-actions github-actions bot locked and limited conversation to collaborators Jul 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

@meganrogge meganrogge

Labels
author-verification-requested Issues potentially verifiable by issue author bug Issue identified by VS Code Team member as probable bug on-release-notes Issue/pull request mentioned in release notes terminal-shell-integration Shell integration infrastructure, command decorations, etc. upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-fixed The underlying upstream issue has been fixed upstream-issue-linked This is an upstream issue that has been reported upstream verified Verification succeeded
Projects
None yet
Milestone
May 2022
Development

No branches or pull requests
4 participants
@roblourens @Tyriar @meganrogge @miguelsolorio