Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clearing terminal keeps find annotations #146010

Closed
rzhao271 opened this issue Mar 24, 2022 · 6 comments
Closed

Clearing terminal keeps find annotations #146010

rzhao271 opened this issue Mar 24, 2022 · 6 comments
Assignees
@Tyriar @meganrogge
Labels
bug Issue identified by VS Code Team member as probable bug terminal-find Relating the terminal's find widget verified Verification succeeded windows VS Code on Windows issues
Milestone
April 2022

Comments

@rzhao271
Copy link
Contributor

Testing #145920

I ran clear while I had the find widget open, and the find result highlighting + sidebar annotations didn't update.
I have shell integration on.
@meganrogge
Copy link
Contributor

They don't for the current line, which is expected. Can you attach a gif? They're getting cleared for me. Also are you on windows?

@meganrogge meganrogge added the info-needed Issue requires more information from poster label Mar 25, 2022
@Tyriar
Copy link
Member

Tyriar commented Mar 25, 2022

@meganrogge after clear on Windows:

image

@Tyriar Tyriar added this to the April 2022 milestone Mar 25, 2022
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug terminal-find Relating the terminal's find widget and removed info-needed Issue requires more information from poster labels Mar 25, 2022
@meganrogge
Copy link
Contributor

meganrogge commented Mar 25, 2022 •
edited
Loading

interesting - on mac:

clear.mov

@rzhao271 rzhao271 added the windows VS Code on Windows issues label Mar 25, 2022
@meganrogge
Copy link
Contributor

I also can't reproduce this on windows. @rzhao271 are you still able to?

@rzhao271
Copy link
Contributor Author

I'm not able to repro the exact bug. I still do see the scroll bar annotations stay even after I clear a query, though.

  1. Open the terminal find widget.
  2. Search for something that has results (like a single letter).
  3. Clear the query.
  4. 🐛 The scroll bar annotations stay.

A screenshot showing the annotations stay after clearing the find widget

@meganrogge
Copy link
Contributor

I've seen that too. For clarity, closing this and will make a new issue for that one.

@meganrogge meganrogge mentioned this issue Apr 19, 2022
Closed
@rzhao271 rzhao271 added the verified Verification succeeded label Apr 28, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jun 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

@meganrogge meganrogge

Labels
bug Issue identified by VS Code Team member as probable bug terminal-find Relating the terminal's find widget verified Verification succeeded windows VS Code on Windows issues
Projects
None yet
Milestone
April 2022
Development

No branches or pull requests
3 participants
@Tyriar @rzhao271 @meganrogge