Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypeError: Cannot read property '0' of undefined when resizing terminal #35110

Closed
alexdima opened this issue Sep 26, 2017 · 1 comment
Closed

TypeError: Cannot read property '0' of undefined when resizing terminal #35110

alexdima opened this issue Sep 26, 2017 · 1 comment
Assignees
@Tyriar
Labels
bug Issue identified by VS Code Team member as probable bug terminal General terminal issues that don't fall under another label upstream Issue identified as 'upstream' component related (exists outside of VS Code) windows VS Code on Windows issues
Milestone
Backlog

Comments

@alexdima
Copy link
Member

Testing #34868

emoji-test.txt

  • save this file as UTF8 with bom (I think it is already)
  • configure "terminal.integrated.scrollback": 5000
  • run chcp 65001
  • run cat emoji-test.txt

terminal-error

TypeError: Cannot read property '1' of undefined
    at TextRenderLayer._clearChar (C:\Alex\vscode-terminal\resources\app\node_modules\xterm\lib\renderer\TextRenderLayer.js:133:41)
    at TextRenderLayer.onGridChanged (C:\Alex\vscode-terminal\resources\app\node_modules\xterm\lib\renderer\TextRenderLayer.js:79:30)
    at C:\Alex\vscode-terminal\resources\app\node_modules\xterm\lib\renderer\Renderer.js:142:60
    at Array.forEach (native)
    at Renderer._refreshLoop (C:\Alex\vscode-terminal\resources\app\node_modules\xterm\lib\renderer\Renderer.js:142:28)
@alexdima alexdima added the terminal General terminal issues that don't fall under another label label Sep 26, 2017
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug upstream Issue identified as 'upstream' component related (exists outside of VS Code) windows VS Code on Windows issues labels Sep 28, 2017
@Tyriar Tyriar added this to the October 2017 milestone Sep 28, 2017
@Tyriar Tyriar modified the milestones: October 2017, Backlog Oct 30, 2017
@alexr00
Copy link
Member

alexr00 commented Sep 17, 2018

Just tried this out with emoji-test.txt (made sure it was saved as UTF-8). I wasn't able to reproduce it.

@alexr00 alexr00 closed this as completed Sep 17, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
bug Issue identified by VS Code Team member as probable bug terminal General terminal issues that don't fall under another label upstream Issue identified as 'upstream' component related (exists outside of VS Code) windows VS Code on Windows issues
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
3 participants
@Tyriar @alexdima @alexr00