Terminal doesn't create link to file if it's path contains non letter-or-digit symbols.

[dmitryshunkov]

• VSCode Version: 1.19.0
• OS Version: Microsoft Windows [Version 10.0.17046.1000]

Steps to Reproduce:

1. Run any command in terminal window with full path in result (for example dir | select FullName).
2. Point on any file item in result.
3. If path contains non letter-or-digit symbol (for example '+'), no link is present.

Reproduces without extensions: Yes

[Tyriar]

Right now link detection is done via a regex here https://github.com/Microsoft/vscode/blob/07e0ad322475d1019f3dbf4761e614e9c9523d76/src/vs/workbench/parts/terminal/electron-browser/terminalLinkHandler.ts#L22

+ is more likely to separate a path than be part of a path so it's not included in the allowed characters list. Eventually I hope the link detection will get a lot better by using a proper parser to scan the text to find the links, let's close this out in favor of xtermjs/xterm.js#583 as that's the first step in improving the links.

[vscodebot]

This issue is being closed to keep the number of issues in our inbox on a manageable level, we are closing issues that have been on the backlog for a long time but have not gained traction: We look at the number of votes the issue has received and the number of duplicate issues filed. If you disagree and feel that this issue is crucial: We are happy to listen and to reconsider.

If you wonder what we are up to, please see our roadmap and issue reporting guidelines.

Thanks for your understanding and happy coding!