Pressing escape in the terminal should clear the selection

[kieferrm]

Testing #46594.

1. Select command output that was previously scrolled out of the viewport
2. Realize you were off by one and selected the wrong output
3. Press ESC
   -> The output is deselected and the terminal scroll to the prompt. If the command was several dozen commands before, I have to go all the way back to correct an off-by-one mistake.

I'm unsure what the right thing is. I'd expect the first ESC to remove the selection and the second to jump back. But I'm not sure how many flows would break with that.

[Tyriar]

The behavior you're after seems reasonable, I think to do that we would need a terminalHasSelection context key (like editorHasSelection) and then add a terminal.integrated.clearSelection to ESC. Open to PRs.

[ddruker]

@Tyriar I can jump on this one. I'd like to complete a few of these "good first issue" issues before moving on. I already have a PR for another one. How does that sound?

[Tyriar]

@ddruker sounds good! Also I just realized that we already have such a context key terminalTextSelected, so it will be easier than I expected 😃

[ddruker]

@Tyriar Just wondering. I have this working by adding it to terminal.integrated.commandsToSkipShell and works well but would you prefer this as a separate configuration called terminal.integrated.clearSelection? We do need to control the keybinding here. Please see the working UX below.

The user can select and when escape is pressed, it will clear the selection. When there is no selection, it will default to normal behavior.

[Tyriar]

@ddruker looks good! We shouldn't have a setting for this as people can unbind the keybinding. For commandsToSkipShell you want to add the command to the default values for that setting:

https://github.com/Microsoft/vscode/blob/b66f0ba3c70b08ffc046a9f1a6f56e0260129540/src/vs/workbench/parts/terminal/electron-browser/terminal.contribution.ts#L207

[ddruker]

Thanks @Tyriar ! I look forward to the feedback.

[Tyriar]

Fixed in #47042, thanks @ddruker 👍