Special characters not correctly displayed in integrated terminal

[renkun-ken]

• VSCode Version: 1.25.0
• OS Version: macOS 10.13.5

Steps to Reproduce:

1. Open git folder in VSCode
2. Open the integrated terminal
3. Run tig and see the special characters not correctly shown if the row is not selected

If a row is selected, then the characters seem correct.

[Tyriar]

Weird, seems to work fine for me:

Could you setup the xterm.js demo and see if you can reproduce there? https://github.com/xtermjs/xterm.js#linux-or-macos

[Tyriar]

It could be a font problem as well, try changing your font (I'm using Hack).

[renkun-ken]

I tried Menlo (VSCode default for macOS) and Monaco (macOS default), both not working.

[Tyriar]

Could you try setup the xterm.js demo and see if it reproduces over there? https://github.com/xtermjs/xterm.js/wiki/Contributing#linux-or-macos

After you get it setup you can enable debug move and view exactly what is being sent to the terminal by the pty. This will help identify at which point the problem is occurring. https://github.com/xtermjs/xterm.js/wiki/Contributing#enabling-debug-mode

[Tyriar]

Upstream issue: xtermjs/xterm.js#1565

[Tyriar]

I couldn't repro as I was using the dynamic texture atlas, see xtermjs/xterm.js#1565 for more info.

[Tyriar]

The fix for this will come in with the July build (1.26), in the meantime this setting should workaround the problem:

"terminal.integrated.experimentalTextureCachingStrategy": "dynamic"

This setting should be stable and will also be the default in the next release.

[renkun-ken]

Thanks! terminal.integrated.experimentalTextureCachingStrategy does work for me.